Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove banner when editing maps visualization #1848

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Remove banner when editing maps visualization #1848

merged 1 commit into from
Jul 7, 2022

Conversation

bandinib-amzn
Copy link
Member

@bandinib-amzn bandinib-amzn commented Jul 5, 2022 •
edited
Loading

Signed-off-by: Bandini Bhopi [email protected]

Description

Fixes #933

Issues Resolved

#933

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@codecov-commenter
Copy link

Codecov Report

Merging #1848 (79e6fac) into main (a9984f6) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1848   +/-   ##
=======================================
  Coverage   67.50%   67.50%           
=======================================
  Files        3074     3073    -1     
  Lines       59127    59118    -9     
  Branches     8988     8986    -2     
=======================================
- Hits        39913    39910    -3     
+ Misses      17030    17023    -7     
- Partials     2184     2185    +1
Impacted Files Coverage Δ
src/plugins/vis_type_vega/public/vega_type.ts 44.44% <ø> (ø)
...ic/application/models/sense_editor/sense_editor.ts 64.00% <0.00%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9984f6...79e6fac. Read the comment docs.

@bandinib-amzn bandinib-amzn marked this pull request as ready for review July 5, 2022 21:05
@bandinib-amzn bandinib-amzn requested a review from a team as a code owner July 5, 2022 21:05
@bandinib-amzn bandinib-amzn changed the title Remove banner Remove banner when editing maps visualization Jul 5, 2022
ashwin-pc
ashwin-pc previously approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kavilla
kavilla previously requested changes Jul 6, 2022
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some internal ips in the commit messages. Could we clean that up?

@kavilla kavilla requested review from kavilla and ashwin-pc July 6, 2022 20:06
@kavilla kavilla dismissed their stale review July 6, 2022 20:06

history cleaned

@kavilla kavilla added the v2.2.0 label Jul 7, 2022
@kavilla kavilla merged commit 53e98a6 into opensearch-project:main Jul 7, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 7, 2022
@bandinib-amzn @github-actions
Remove banner from when editing maps visualization (#1848)
47c819c 
Issue resolved:
#933

Signed-off-by: Bandini Bhopi <[email protected]>
(cherry picked from commit 53e98a6)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 7, 2022
Merged
@bandinib-amzn bandinib-amzn deleted the remove-banner branch July 7, 2022 22:58
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jul 12, 2022
@bandinib-amzn @kavilla
Remove banner from when editing maps visualization (opensearch-projec…
af04540 
…t#1848)

Issue resolved:
opensearch-project#933

Signed-off-by: Bandini Bhopi <[email protected]>
kavilla pushed a commit that referenced this pull request Jul 27, 2022
@opensearch-trigger-bot @bandinib-amzn
Remove banner from when editing maps visualization (#1848) (#1856)
42bed60 
Issue resolved:
#933

Signed-off-by: Bandini Bhopi <[email protected]>
(cherry picked from commit 53e98a6)

Co-authored-by: Bandini <[email protected]>
CPTNB pushed a commit to CPTNB/OpenSearch-Dashboards that referenced this pull request Aug 8, 2022
@bandinib-amzn @CPTNB
Remove banner from when editing maps visualization (opensearch-projec…
aec4d83 
…t#1848)

Issue resolved:
opensearch-project#933

Signed-off-by: Bandini Bhopi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@kavilla kavilla kavilla approved these changes

Assignees
No one assigned
Labels
backport 2.x v2.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] "Experimental" banner when editing maps visualization
4 participants
@bandinib-amzn @codecov-commenter @kavilla @ashwin-pc