-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Non-Inclusive Lanuage] Replace references to master branch with main #1780
Conversation
b921165
to
6eebf7f
Compare
Signed-off-by: kaddy645 <[email protected]>
packages/osd-test/src/failed_tests_reporter/run_failed_tests_reporter_cli.ts
Outdated
Show resolved
Hide resolved
Looking good so far! For the first pass just a few comments but I think this can be ready for review after addressing. If anything was missed we can just create subsequent issues. For the git commit though can you update the commit description to include the details you include in the PR. For example, including the issue. Thanks @kaddy645! |
Signed-off-by: kaddy645 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1780 +/- ##
=======================================
Coverage 67.50% 67.51%
=======================================
Files 3073 3073
Lines 59069 59069
Branches 8963 8963
=======================================
+ Hits 39877 39881 +4
+ Misses 17008 17005 -3
+ Partials 2184 2183 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1780-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7c8eee410da10b35af60430236c77ab4ccf2ba03
# Push it to GitHub
git push --set-upstream origin backport/backport-1780-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…opensearch-project#1780) In this change, we are replacing references to master branch with main Issue: opensearch-project#1691 Signed-off-by: kaddy645 <[email protected]> (cherry picked from commit 7c8eee4)
…opensearch-project#1780) In this change, we are replacing references to master branch with main Issue: opensearch-project#1691 Signed-off-by: kaddy645 <[email protected]> (cherry picked from commit 7c8eee4) Signed-off-by: <Kartik Desai [email protected]>
…opensearch-project#1780) In this change, we are replacing references to master branch with main Issue: opensearch-project#1691 Signed-off-by: kaddy645 <[email protected]> (cherry picked from commit 7c8eee4) Signed-off-by: Kartik Desai <[email protected]>
…#1780) (#1790) In this change, we are replacing references to master branch with main Issue: #1691 Signed-off-by: kaddy645 <[email protected]> (cherry picked from commit 7c8eee4) Signed-off-by: Kartik Desai <[email protected]> Co-authored-by: Kartik Desai <[email protected]>
Signed-off-by: kaddy645 [email protected]
Description
In this change, we are replacing references to master branch with main
Issues Resolved
#1691
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr