-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deprecation] Deprecate setupMaster in favor of setupClusterManager #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
previously approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
joshuarrrr
previously approved these changes
Jun 17, 2022
As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories We are deprecating setupMaster in favor of setupClusterManager Signed-off-by: manasvinibs <[email protected]>
ananzh
approved these changes
Jun 20, 2022
joshuarrrr
approved these changes
Jun 20, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2022
…1752) As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories We are deprecating setupMaster in favor of setupClusterManager Signed-off-by: manasvinibs <[email protected]> (cherry picked from commit 9e508e7)
kavilla
pushed a commit
that referenced
this pull request
Jun 22, 2022
…1752) As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories We are deprecating setupMaster in favor of setupClusterManager Signed-off-by: manasvinibs <[email protected]> (cherry picked from commit 9e508e7) Signed-off-by: Manasvini B Suryanarayana <[email protected]>
manasvinibs
added a commit
that referenced
this pull request
Jun 22, 2022
…1752) (#1769) As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories We are deprecating setupMaster in favor of setupClusterManager Signed-off-by: manasvinibs <[email protected]> (cherry picked from commit 9e508e7) Signed-off-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]>
cliu123
pushed a commit
to cliu123/OpenSearch-Dashboards
that referenced
this pull request
Jun 30, 2022
…pensearch-project#1752) (opensearch-project#1769) As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories We are deprecating setupMaster in favor of setupClusterManager Signed-off-by: manasvinibs <[email protected]> (cherry picked from commit 9e508e7) Signed-off-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]>
cliu123
pushed a commit
to cliu123/OpenSearch-Dashboards
that referenced
this pull request
Jun 30, 2022
…pensearch-project#1752) (opensearch-project#1769) As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories We are deprecating setupMaster in favor of setupClusterManager Signed-off-by: manasvinibs <[email protected]> (cherry picked from commit 9e508e7) Signed-off-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: manasvis [email protected]
Description
As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories
Every repository that uses non-inclusive words should replace all the non-inclusive usages in the code base.
We are deprecating setupMaster in favor of setupClusterManager
Issues Resolved
#1689
Parent
#1318
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr