Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecation] Deprecate setupMaster in favor of setupClusterManager #1752

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

manasvinibs
Copy link
Member

@manasvinibs manasvinibs commented Jun 15, 2022

Signed-off-by: manasvis [email protected]

Description

As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories

Every repository that uses non-inclusive words should replace all the non-inclusive usages in the code base.

We are deprecating setupMaster in favor of setupClusterManager

Issues Resolved

#1689

Parent

#1318

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@manasvinibs manasvinibs requested a review from a team as a code owner June 15, 2022 22:49
@manasvinibs manasvinibs self-assigned this Jun 15, 2022
ananzh
ananzh previously approved these changes Jun 17, 2022
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joshuarrrr
joshuarrrr previously approved these changes Jun 17, 2022
As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories
We are deprecating setupMaster in favor of setupClusterManager

Signed-off-by: manasvinibs <[email protected]>
@joshuarrrr joshuarrrr merged commit 9e508e7 into opensearch-project:main Jun 20, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 20, 2022
…1752)

As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories
We are deprecating setupMaster in favor of setupClusterManager

Signed-off-by: manasvinibs <[email protected]>
(cherry picked from commit 9e508e7)
kavilla pushed a commit that referenced this pull request Jun 22, 2022
…1752)

As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories
We are deprecating setupMaster in favor of setupClusterManager

Signed-off-by: manasvinibs <[email protected]>
(cherry picked from commit 9e508e7)

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
manasvinibs added a commit that referenced this pull request Jun 22, 2022
…1752) (#1769)

As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories
We are deprecating setupMaster in favor of setupClusterManager

Signed-off-by: manasvinibs <[email protected]>
(cherry picked from commit 9e508e7)

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

Co-authored-by: Manasvini B Suryanarayana <[email protected]>
@kavilla kavilla linked an issue Jun 23, 2022 that may be closed by this pull request
cliu123 pushed a commit to cliu123/OpenSearch-Dashboards that referenced this pull request Jun 30, 2022
…pensearch-project#1752) (opensearch-project#1769)

As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories
We are deprecating setupMaster in favor of setupClusterManager

Signed-off-by: manasvinibs <[email protected]>
(cherry picked from commit 9e508e7)

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

Co-authored-by: Manasvini B Suryanarayana <[email protected]>
cliu123 pushed a commit to cliu123/OpenSearch-Dashboards that referenced this pull request Jun 30, 2022
…pensearch-project#1752) (opensearch-project#1769)

As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories
We are deprecating setupMaster in favor of setupClusterManager

Signed-off-by: manasvinibs <[email protected]>
(cherry picked from commit 9e508e7)

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

Co-authored-by: Manasvini B Suryanarayana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Deprecation] Deprecate setupMaster in favor of setupClusterManager
3 participants