Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Josh Romero as co-maintainer #1682

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Adds Josh Romero as co-maintainer #1682

merged 1 commit into from
Jun 7, 2022

Conversation

tmarkley
Copy link
Contributor

@tmarkley tmarkley commented Jun 7, 2022 •
edited
Loading

Description

I nominate Josh Romero (@joshuarrrr) as co-maintainer and the OpenSearch Dashboards maintainers unanimously approve this nomination.

Josh has consistently contributed high-quality PRs and is actively improving both the developer and user experience through contributions such as migrating all mocha tests to jest (#215) and working with the community to redesign the OpenSearch Dashboards global header (#1583).

https://github.com/opensearch-project/OpenSearch-Dashboards/pulls/joshuarrrr

Josh privately accepted this nomination.

Thank you for your contributions Josh!

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

Adds Josh Romero as co-maintainer
d26f516 
I nominate Josh Romero as co-maintainer and the OpenSearch Dashboards
maintainers unanimously approve this nomination.

Josh has consistently contributed high-quality PRs and is actively
improving both the developer and user experience through contributions
such as migrating all mocha tests to jest and working with the community
to redesign the OpenSearch Dashboards global header.

https://github.com/opensearch-project/OpenSearch-Dashboards/pulls/joshuarrrr

Josh privately accepted this nomination.

Thank you for your contributions Josh!

Signed-off-by: Tommy Markley <[email protected]>
@tmarkley tmarkley requested a review from a team as a code owner June 7, 2022 15:19
seanneumann
seanneumann approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this!

@tmarkley tmarkley merged commit 4e117c3 into opensearch-project:main Jun 7, 2022
@tmarkley
Copy link
Contributor Author

tmarkley commented Jun 7, 2022

I've marked Josh as a maintainer in https://github.com/orgs/opensearch-project/teams/opensearch-dashboards-core

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 7, 2022
@github-actions
Adds Josh Romero as co-maintainer (#1682)
36e3912 
I nominate Josh Romero (@joshuarrrr) as co-maintainer and the
OpenSearch Dashboards maintainers unanimously approve this
nomination.

Josh has consistently contributed high-quality PRs and is actively
improving both the developer and user experience through contributions
such as migrating all mocha tests to jest and working with the community
to redesign the OpenSearch Dashboards global header.

https://github.com/opensearch-project/OpenSearch-Dashboards/pulls/joshuarrrr

Josh privately accepted this nomination.

Thank you for your contributions Josh!

Signed-off-by: Tommy Markley <[email protected]>
(cherry picked from commit 4e117c3)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 7, 2022
Merged
kavilla pushed a commit that referenced this pull request Jun 7, 2022
@opensearch-trigger-bot
Adds Josh Romero as co-maintainer (#1682) (#1683)
3904166 
I nominate Josh Romero (@joshuarrrr) as co-maintainer and the
OpenSearch Dashboards maintainers unanimously approve this
nomination.

Josh has consistently contributed high-quality PRs and is actively
improving both the developer and user experience through contributions
such as migrating all mocha tests to jest and working with the community
to redesign the OpenSearch Dashboards global header.

https://github.com/opensearch-project/OpenSearch-Dashboards/pulls/joshuarrrr

Josh privately accepted this nomination.

Thank you for your contributions Josh!

Signed-off-by: Tommy Markley <[email protected]>
(cherry picked from commit 4e117c3)

Co-authored-by: Tommy Markley <[email protected]>
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 8, 2022
@kavilla
Adds Josh Romero as co-maintainer (opensearch-project#1682)
785baa9 
I nominate Josh Romero (@joshuarrrr) as co-maintainer and the 
OpenSearch Dashboards maintainers unanimously approve this 
nomination.

Josh has consistently contributed high-quality PRs and is actively
improving both the developer and user experience through contributions
such as migrating all mocha tests to jest and working with the community
to redesign the OpenSearch Dashboards global header.

https://github.com/opensearch-project/OpenSearch-Dashboards/pulls/joshuarrrr

Josh privately accepted this nomination.

Thank you for your contributions Josh!

Signed-off-by: Tommy Markley <[email protected]>
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 8, 2022
@kavilla
Adds Josh Romero as co-maintainer (opensearch-project#1682)
2e14a9d 
I nominate Josh Romero (@joshuarrrr) as co-maintainer and the 
OpenSearch Dashboards maintainers unanimously approve this 
nomination.

Josh has consistently contributed high-quality PRs and is actively
improving both the developer and user experience through contributions
such as migrating all mocha tests to jest and working with the community
to redesign the OpenSearch Dashboards global header.

https://github.com/opensearch-project/OpenSearch-Dashboards/pulls/joshuarrrr

Josh privately accepted this nomination.

Thank you for your contributions Josh!

Signed-off-by: Tommy Markley <[email protected]>
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 16, 2022
@kavilla
Adds Josh Romero as co-maintainer (opensearch-project#1682)
70b47fa 
I nominate Josh Romero (@joshuarrrr) as co-maintainer and the 
OpenSearch Dashboards maintainers unanimously approve this 
nomination.

Josh has consistently contributed high-quality PRs and is actively
improving both the developer and user experience through contributions
such as migrating all mocha tests to jest and working with the community
to redesign the OpenSearch Dashboards global header.

https://github.com/opensearch-project/OpenSearch-Dashboards/pulls/joshuarrrr

Josh privately accepted this nomination.

Thank you for your contributions Josh!

Signed-off-by: Tommy Markley <[email protected]>
cliu123 pushed a commit to cliu123/OpenSearch-Dashboards that referenced this pull request Jun 30, 2022
@opensearch-trigger-bot
Adds Josh Romero as co-maintainer (opensearch-project#1682) (opensear…
063babc 
…ch-project#1683)

I nominate Josh Romero (@joshuarrrr) as co-maintainer and the
OpenSearch Dashboards maintainers unanimously approve this
nomination.

Josh has consistently contributed high-quality PRs and is actively
improving both the developer and user experience through contributions
such as migrating all mocha tests to jest and working with the community
to redesign the OpenSearch Dashboards global header.

https://github.com/opensearch-project/OpenSearch-Dashboards/pulls/joshuarrrr

Josh privately accepted this nomination.

Thank you for your contributions Josh!

Signed-off-by: Tommy Markley <[email protected]>
(cherry picked from commit 4e117c3)

Co-authored-by: Tommy Markley <[email protected]>
cliu123 pushed a commit to cliu123/OpenSearch-Dashboards that referenced this pull request Jun 30, 2022
@opensearch-trigger-bot
Adds Josh Romero as co-maintainer (opensearch-project#1682) (opensear…
ee51e14 
…ch-project#1683)

I nominate Josh Romero (@joshuarrrr) as co-maintainer and the
OpenSearch Dashboards maintainers unanimously approve this
nomination.

Josh has consistently contributed high-quality PRs and is actively
improving both the developer and user experience through contributions
such as migrating all mocha tests to jest and working with the community
to redesign the OpenSearch Dashboards global header.

https://github.com/opensearch-project/OpenSearch-Dashboards/pulls/joshuarrrr

Josh privately accepted this nomination.

Thank you for your contributions Josh!

Signed-off-by: Tommy Markley <[email protected]>
(cherry picked from commit 4e117c3)

Co-authored-by: Tommy Markley <[email protected]>
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Aug 10, 2022
Adds Josh Romero as co-maintainer (opensearch-project#1682)
9c19a3c 
I nominate Josh Romero (@joshuarrrr) as co-maintainer and the 
OpenSearch Dashboards maintainers unanimously approve this 
nomination.

Josh has consistently contributed high-quality PRs and is actively
improving both the developer and user experience through contributions
such as migrating all mocha tests to jest and working with the community
to redesign the OpenSearch Dashboards global header.

https://github.com/opensearch-project/OpenSearch-Dashboards/pulls/joshuarrrr

Josh privately accepted this nomination.

Thank you for your contributions Josh!

Signed-off-by: Tommy Markley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@seanneumann seanneumann seanneumann approved these changes

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@boktorbb boktorbb Awaiting requested review from boktorbb

@mihirsoni mihirsoni Awaiting requested review from mihirsoni

Assignees
No one assigned
Labels
backport 2.x v2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmarkley @seanneumann @kavilla @joshuarrrr