Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic to integrate dashboards-maps plugin with OSD for custom GeoJSON upload feature #1632

Merged
merged 2 commits into from
May 31, 2022
Merged

Logic to integrate dashboards-maps plugin with OSD for custom GeoJSON upload feature #1632

merged 2 commits into from
May 31, 2022

Conversation

Shivamdhar
Copy link
Contributor

@Shivamdhar Shivamdhar commented May 27, 2022 •
edited
Loading

Signed-off-by: Shivam Dhar [email protected]

Description

dashboards-maps repository contains cutomImportMap plugin which will be used for uploading custom GeoJSON files via region map plugin in OSD.

This PR helps in establishing the connection via usage of appropriate props and interfaces so that the extra tab (new component that will be added in dashboards-maps repo for taking user input) appears at the correct place in the region map visualization section.

Issues Resolved

#1408

Check List

  • New functionality includes testing - Not required as this PR only adds integration logic for plugin code to work with OSD
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@Shivamdhar Shivamdhar requested a review from a team as a code owner May 27, 2022 22:17
ashwin-pc
ashwin-pc reviewed May 27, 2022
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small callout, the rest looks good to me!

src/plugins/region_map/public/plugin.ts Outdated Show resolved Hide resolved
src/plugins/region_map/public/plugin.ts Outdated Show resolved Hide resolved
@ashwin-pc ashwin-pc requested a review from a team May 27, 2022 23:32
@Shivamdhar Shivamdhar requested a review from ashwin-pc May 27, 2022 23:55
ashwin-pc
ashwin-pc approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM!

@ashwin-pc ashwin-pc requested a review from a team May 28, 2022 00:15
@codecov-commenter
Copy link

Codecov Report

Merging #1632 (756e65c) into main (665424e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1632   +/-   ##
=======================================
  Coverage   68.08%   68.08%           
=======================================
  Files        3072     3072           
  Lines       59015    59015           
  Branches     8924     8924           
=======================================
  Hits        40183    40183           
  Misses      16645    16645           
  Partials     2187     2187

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665424e...756e65c. Read the comment docs.

ananzh
ananzh approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashwin-pc ashwin-pc merged commit 6d1675c into opensearch-project:main May 31, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 31, 2022
@Shivamdhar @github-actions
Logic to integrate dashboards-maps plugin with OSD for custom GeoJSON…
0e81c60 
… upload feature (#1632)

* adds logic to accommodate import custom map tab from dashboards-maps plugin

Signed-off-by: Shivam Dhar <[email protected]>

* adds type to http and notifications

Signed-off-by: Shivam Dhar <[email protected]>

Co-authored-by: Shivam Dhar <[email protected]>
(cherry picked from commit 6d1675c)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 31, 2022
Merged
@tmarkley tmarkley added v2.1.0 maps Issues or PRs related to the Maps Service enhancement New feature or request labels Jun 1, 2022
@kavilla kavilla mentioned this pull request Jun 2, 2022
Closed
2 tasks
tmarkley pushed a commit that referenced this pull request Jun 8, 2022
@Shivamdhar
Logic to integrate dashboards-maps plugin with OSD for custom GeoJSON…
fda1d6a 
… upload feature (#1632)

* adds logic to accommodate import custom map tab from dashboards-maps plugin

Signed-off-by: Shivam Dhar <[email protected]>

* adds type to http and notifications

Signed-off-by: Shivam Dhar <[email protected]>

Co-authored-by: Shivam Dhar <[email protected]>
(cherry picked from commit 6d1675c)
tmarkley pushed a commit that referenced this pull request Jun 8, 2022
@opensearch-trigger-bot
Logic to integrate dashboards-maps plugin with OSD for custom GeoJSON…
4cd25dd 
… upload feature (#1632) (#1645)

* adds logic to accommodate import custom map tab from dashboards-maps plugin
* adds type to http and notifications

Signed-off-by: Shivam Dhar <[email protected]>
(cherry picked from commit 6d1675c)
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 8, 2022
@Shivamdhar @kavilla
Logic to integrate dashboards-maps plugin with OSD for custom GeoJSON…
9f94a7c 
… upload feature (opensearch-project#1632)

* adds logic to accommodate import custom map tab from dashboards-maps plugin

Signed-off-by: Shivam Dhar <[email protected]>

* adds type to http and notifications

Signed-off-by: Shivam Dhar <[email protected]>

Co-authored-by: Shivam Dhar <[email protected]>
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 8, 2022
@Shivamdhar @kavilla
Logic to integrate dashboards-maps plugin with OSD for custom GeoJSON…
a8899d1 
… upload feature (opensearch-project#1632)

* adds logic to accommodate import custom map tab from dashboards-maps plugin

Signed-off-by: Shivam Dhar <[email protected]>

* adds type to http and notifications

Signed-off-by: Shivam Dhar <[email protected]>

Co-authored-by: Shivam Dhar <[email protected]>
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 16, 2022
@Shivamdhar @kavilla
Logic to integrate dashboards-maps plugin with OSD for custom GeoJSON…
71094ca 
… upload feature (opensearch-project#1632)

* adds logic to accommodate import custom map tab from dashboards-maps plugin

Signed-off-by: Shivam Dhar <[email protected]>

* adds type to http and notifications

Signed-off-by: Shivam Dhar <[email protected]>

Co-authored-by: Shivam Dhar <[email protected]>
cliu123 pushed a commit to cliu123/OpenSearch-Dashboards that referenced this pull request Jun 30, 2022
@opensearch-trigger-bot
Logic to integrate dashboards-maps plugin with OSD for custom GeoJSON…
371b5d6 
… upload feature (opensearch-project#1632) (opensearch-project#1645)

* adds logic to accommodate import custom map tab from dashboards-maps plugin
* adds type to http and notifications

Signed-off-by: Shivam Dhar <[email protected]>
(cherry picked from commit 6d1675c)
cliu123 pushed a commit to cliu123/OpenSearch-Dashboards that referenced this pull request Jun 30, 2022
@opensearch-trigger-bot
Logic to integrate dashboards-maps plugin with OSD for custom GeoJSON…
5eba470 
… upload feature (opensearch-project#1632) (opensearch-project#1645)

* adds logic to accommodate import custom map tab from dashboards-maps plugin
* adds type to http and notifications

Signed-off-by: Shivam Dhar <[email protected]>
(cherry picked from commit 6d1675c)
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Aug 10, 2022
@Shivamdhar
Logic to integrate dashboards-maps plugin with OSD for custom GeoJSON…
a5cae28 
… upload feature (opensearch-project#1632)

* adds logic to accommodate import custom map tab from dashboards-maps plugin

Signed-off-by: Shivam Dhar <[email protected]>

* adds type to http and notifications

Signed-off-by: Shivam Dhar <[email protected]>

Co-authored-by: Shivam Dhar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@VijayanB VijayanB VijayanB approved these changes

Assignees
No one assigned
Labels
backport 2.x enhancement New feature or request maps Issues or PRs related to the Maps Service v2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Shivamdhar @codecov-commenter @VijayanB @ashwin-pc @ananzh @tmarkley