Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Update Dockerfile chrome version to match #1626

Merged
merged 1 commit into from
May 26, 2022
Merged

[Tests] Update Dockerfile chrome version to match #1626

merged 1 commit into from
May 26, 2022

Conversation

joshuarrrr
Copy link
Member

package.json and yarn.lock already updated to 100.0.0

Signed-off-by: Josh Romero [email protected]

Description

Updates the version of Chrome installed by Dockerfile, which is used for running Jenkins tests

Issues Resolved

Fixes #1623

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@joshuarrrr
[Tests] Update Dockerfile chrome version to match
13823e6 
package.json and yarn.lock already updated to 100.0.0

Signed-off-by: Josh Romero <[email protected]>
@joshuarrrr joshuarrrr requested a review from a team as a code owner May 26, 2022 00:37
@codecov-commenter
Copy link

Codecov Report

Merging #1626 (13823e6) into main (de1a689) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1626   +/-   ##
=======================================
  Coverage   68.08%   68.08%           
=======================================
  Files        3072     3072           
  Lines       59015    59015           
  Branches     8924     8924           
=======================================
  Hits        40183    40183           
  Misses      16645    16645           
  Partials     2187     2187

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1a689...13823e6. Read the comment docs.

kavilla
kavilla approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kavilla kavilla added the ci label May 26, 2022
@kavilla
Copy link
Member

kavilla commented May 26, 2022

Probably can backport this to 2.x and 2.0 correct?

@joshuarrrr
Copy link
Member Author

Probably can backport this to 2.x and 2.0 correct?

Yep, it should be backported to both, because they already have #1552

@joshuarrrr joshuarrrr merged commit 665424e into opensearch-project:main May 26, 2022
@joshuarrrr joshuarrrr deleted the tests/bump-docker-chrome-100 branch May 26, 2022 18:32
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 26, 2022
@joshuarrrr @github-actions
[Tests] Update Dockerfile chrome version to match (#1626)
4084773 
package.json and yarn.lock already updated to 100.0.0

Signed-off-by: Josh Romero <[email protected]>
(cherry picked from commit 665424e)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 26, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 26, 2022
@joshuarrrr @github-actions
[Tests] Update Dockerfile chrome version to match (#1626)
3773caf 
package.json and yarn.lock already updated to 100.0.0

Signed-off-by: Josh Romero <[email protected]>
(cherry picked from commit 665424e)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 26, 2022
Merged
joshuarrrr added a commit that referenced this pull request May 26, 2022
@opensearch-trigger-bot @joshuarrrr
[Tests] Update Dockerfile chrome version to match (#1626) (#1628)
3e2ff81 
package.json and yarn.lock already updated to 100.0.0

Signed-off-by: Josh Romero <[email protected]>
(cherry picked from commit 665424e)

Co-authored-by: Josh Romero <[email protected]>
joshuarrrr added a commit that referenced this pull request May 26, 2022
@opensearch-trigger-bot @joshuarrrr
[Tests] Update Dockerfile chrome version to match (#1626) (#1627)
2a10962 
package.json and yarn.lock already updated to 100.0.0

Signed-off-by: Josh Romero <[email protected]>
(cherry picked from commit 665424e)

Co-authored-by: Josh Romero <[email protected]>
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 8, 2022
@joshuarrrr @kavilla
[Tests] Update Dockerfile chrome version to match (opensearch-project…
3eaa817 
…#1626)

package.json and yarn.lock already updated to 100.0.0

Signed-off-by: Josh Romero <[email protected]>
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 8, 2022
@joshuarrrr @kavilla
[Tests] Update Dockerfile chrome version to match (opensearch-project…
5bf36ad 
…#1626)

package.json and yarn.lock already updated to 100.0.0

Signed-off-by: Josh Romero <[email protected]>
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 16, 2022
@joshuarrrr @kavilla
[Tests] Update Dockerfile chrome version to match (opensearch-project…
a47e51d 
…#1626)

package.json and yarn.lock already updated to 100.0.0

Signed-off-by: Josh Romero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@kavilla kavilla kavilla approved these changes

Assignees

@joshuarrrr joshuarrrr

Labels
backport 2.x ci v2.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tests] Update chromedriver version in Dockerfile
4 participants
@joshuarrrr @codecov-commenter @kavilla @ananzh