[Rename] visualizations plugin #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihirsoni
reviewed
Mar 11, 2021
| @@ -393,7 +393,7 @@ export const buildPipeline = async (vis: Vis, params: BuildPipelineParams) => { | |||
| const { uiState, title } = vis; | |||
|
|
|||
| // context | |||
| let pipeline = `kibana | kibana_context `; | |||
| let pipeline = `opensearch_dashboards | opensearch_dashboards_context `; | |||
There was a problem hiding this comment.
Is this in expression context ? if so @boktorbb-amzn has replaced with opensearchDashboards
There was a problem hiding this comment.
looks like it. we should sync up about that or w/e gets merged in.
mihirsoni
reviewed
Mar 11, 2021
src/plugins/visualizations/server/saved_objects/visualization_migrations.ts
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
src/plugins/visualizations/server/saved_objects/visualization_migrations.ts
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
boktorbb
suggested changes
Mar 11, 2021
src/plugins/visualizations/server/saved_objects/visualization_migrations.ts
Outdated
Show resolved
Hide resolved
src/plugins/visualizations/server/saved_objects/visualization_migrations.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
kavilla
force-pushed
the
rename-visualization
branch
from
91867d9 to
896fda3
Compare
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
* [Rename] visualizations plugin Signed-off-by: Kawika Avilla <[email protected]> * Forgot to save rename Signed-off-by: Kawika Avilla <[email protected]> * Address PR comments Signed-off-by: Kawika Avilla <[email protected]>
kavilla
added a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] visualizations plugin Signed-off-by: Kawika Avilla <[email protected]> * Forgot to save rename Signed-off-by: Kawika Avilla <[email protected]> * Address PR comments Signed-off-by: Kawika Avilla <[email protected]>
mihirsoni
pushed a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] visualizations plugin Signed-off-by: Kawika Avilla <[email protected]> * Forgot to save rename Signed-off-by: Kawika Avilla <[email protected]> * Address PR comments Signed-off-by: Kawika Avilla <[email protected]>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 15, 2023
Signed-off-by: Yulong Ruan <[email protected]>
wanglam
pushed a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Sep 21, 2023
…) (opensearch-project#169) (cherry picked from commit 1d95a09) Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 11, 2024
…roject#159)" This reverts commit 47e10e4.
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 14, 2024
…roject#159)" This reverts commit 47e10e4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#37
Description of changes:
Rename files and variables within plugins/visualizations
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.