-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds code coverage reporting #1478
Conversation
* Renames build and test workflow to eliminate ambiguity. * Adds coverage generation for jest and mocha tests. * Expands coverage collection for jest tests. * Utilizes `lcov` reporter as well as text summary reporter. Resolves opensearch-project#1339 Prerequisite for opensearch-project#1035 Signed-off-by: Tommy Markley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1478 +/- ##
=======================================
Coverage ? 68.09%
=======================================
Files ? 3072
Lines ? 59036
Branches ? 8927
=======================================
Hits ? 40200
Misses ? 16650
Partials ? 2186 Continue to review full report at Codecov.
|
* Renames build and test workflow to eliminate ambiguity. * Adds coverage generation for jest and mocha tests. * Expands coverage collection for jest tests. * Utilizes `lcov` reporter as well as text summary reporter. Resolves opensearch-project#1339 Prerequisite for opensearch-project#1035 Signed-off-by: Tommy Markley <[email protected]>
* Renames build and test workflow to eliminate ambiguity. * Adds coverage generation for jest and mocha tests. * Expands coverage collection for jest tests. * Utilizes `lcov` reporter as well as text summary reporter. Resolves #1339 Prerequisite for #1035 Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 1caf907)
* Renames build and test workflow to eliminate ambiguity. * Adds coverage generation for jest and mocha tests. * Expands coverage collection for jest tests. * Utilizes `lcov` reporter as well as text summary reporter. Resolves #1339 Prerequisite for #1035 Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 1caf907) Co-authored-by: Tommy Markley <[email protected]> Co-authored-by: abbyhu2000 <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1478-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1caf90752d8e34ceece81d8a69f6ec79aabfa9c1
# Push it to GitHub
git push --set-upstream origin backport/backport-1478-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-1478-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1caf90752d8e34ceece81d8a69f6ec79aabfa9c1
# Push it to GitHub
git push --set-upstream origin backport/backport-1478-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3 Then, create a pull request where the |
* Renames build and test workflow to eliminate ambiguity. * Adds coverage generation for jest and mocha tests. * Expands coverage collection for jest tests. * Utilizes `lcov` reporter as well as text summary reporter. Resolves opensearch-project#1339 Prerequisite for opensearch-project#1035 Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 1caf907)
* Renames build and test workflow to eliminate ambiguity. * Adds coverage generation for jest and mocha tests. * Expands coverage collection for jest tests. * Utilizes `lcov` reporter as well as text summary reporter. Resolves opensearch-project#1339 Prerequisite for opensearch-project#1035 Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 1caf907)
* Renames build and test workflow to eliminate ambiguity. * Adds coverage generation for jest and mocha tests. * Expands coverage collection for jest tests. * Utilizes `lcov` reporter as well as text summary reporter. Resolves opensearch-project#1339 Prerequisite for opensearch-project#1035 Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 1caf907)
* Add retrying flaky jest tests (opensearch-project#2967) * Add code coverage reporting (opensearch-project#1478) * Report `done` on async jest failures Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Fix unit tests of ExecutionContract throwing AbortError Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Fix unit tests of ExecutionContract throwing AbortError Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Fix unit tests of ExecutionContract throwing AbortError Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (#1306) * Fix JUnit Reporter test (#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (#1442) * Add code coverage reporting (#1478) * Add release build verification workflow (#1502) * Add Windows CI to the workflow (#2966) * Add retrying flaky jest tests (#2967) * Record functional test artifacts in case of failure (#3190) * Increase timeout waiting for the exiting of an optimizer worker (#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <[email protected]> Signed-off-by: Miki <[email protected]>
…ject#3299) * Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <[email protected]> Signed-off-by: Miki <[email protected]>
…ject#3299) * Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <[email protected]> Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (opensearch-project#1306) * Fix JUnit Reporter test (opensearch-project#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (opensearch-project#1442) * Add code coverage reporting (opensearch-project#1478) * Add release build verification workflow (opensearch-project#1502) * Add Windows CI to the workflow (opensearch-project#2966) * Add retrying flaky jest tests (opensearch-project#2967) * Record functional test artifacts in case of failure (opensearch-project#3190) * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (opensearch-project#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Backport PR: opensearch-project#3299 Signed-off-by: Miki <[email protected]>
* Run GitHub workflow unit tests in band (#1306) * Fix JUnit Reporter test (#1338) * Add src/test_utils/ and src/core paths to the target clean patterns (#1442) * Add code coverage reporting (#1478) * Add release build verification workflow (#1502) * Add Windows CI to the workflow (#2966) * Add retrying flaky jest tests (#2967) * Record functional test artifacts in case of failure (#3190) * Increase timeout waiting for the exiting of an optimizer worker (#3193) * Improve yarn's performance in workflows by caching yarn's cache folder (#3194) * Fix the version of Chrome to 107 to match `[email protected]`, the last that works on NodeJS v10 * Prevent `AbortError` from breaking unit tests for ExecutionContract Signed-off-by: Miki <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Miki <[email protected]>
Description
lcov
reporter as well as text summary reporter.See https://codecov.io/gh/tmarkley/OpenSearch-Dashboards/tree/95c85fe9ac0a6ace26cd9ee36854759db42fce80 for a successful run, from https://github.com/tmarkley/OpenSearch-Dashboards/runs/6082789296?check_suite_focus=true.
Example output
Issues Resolved
Resolves #1339
Prerequisite for #1035
Check List