-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes UI Framework KUI doc site #1379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks good. Just a question about removing the grunt tasks to compile the scss for ui-framework
I successfully ran the
|
Ran that on |
Looks like this doesn't actually had an impact on the CVE and the CVE was addressed. Given that has conflicts and the CVE was addressed I will remove the |
@kavilla the CVE was not addressed. |
Apologies, when I checked the CVE it was automatically resolved but I guess it re-opened 4 days ago. I see there are conflicts here. |
Similar with the other PR with the lock file being changed do we see any potential of breakage with plugins? Grant it is the lock file although we do is for handling a lot of our resolutions. Thanks! |
Yeah I think there could be some risk here with the amount of dependencies that we're removing. I'm okay to hold off until next week and merge after RC1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking for rc1 release.
We need to merge these CVE PRs in for RC1 to address any breaking changes.
* KUI components are no longer being developed and the dependencies for the doc site are related to CVEs. * Refactors grunt tasks for compiling KUI CSS. * Removes doc site related grunt tasks. * Removes all unused dependencies from the osd/ui-framework package. ### Issues Prerequisite for resolving opensearch-project#1096 (along with the EUI upgrade) Signed-off-by: Tommy Markley <[email protected]>
Description
Issues Resolved
Resolves #1096
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr