[Branding] assets folder and SSL support #1329
Merged
+64
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding `assets` folder that gets served up under UI for ease of us. SSL support when OpenSearch Dashboards SSL is enabled. Issue Resolved: opensearch-project#1164 Signed-off-by: Kawika Avilla <[email protected]>
|
I had to create a new issue for more tests since it's more involved: #1330. One thing to guarantee is that this will have no impact and will go unnoticed on default behavior (SSL not enabled) so this is a relatively safe change. |
ananzh
approved these changes
Mar 8, 2022
| @@ -89,6 +89,7 @@ export class CoreApp { | |||
| } | |||
| private registerStaticDirs(coreSetup: InternalCoreSetup) { | |||
| coreSetup.http.registerStaticDir('/ui/{path*}', Path.resolve(__dirname, './assets')); | |||
| coreSetup.http.registerStaticDir('/ui/assets/{path*}', fromRoot('assets')); | |||
|
|
|||
There was a problem hiding this comment.
Should we remove this blank line or add another blank one after line 91
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
Adding `assets` folder that gets served up under UI for ease of us. SSL support when OpenSearch Dashboards SSL is enabled. Issue Resolved: #1164 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 289ad24)
ananzh
pushed a commit
that referenced
this pull request
Mar 8, 2022
Adding `assets` folder that gets served up under UI for ease of us. SSL support when OpenSearch Dashboards SSL is enabled. Issue Resolved: #1164 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 289ad24) Co-authored-by: Kawika Avilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
assetsfolder that gets served up under UI for ease of us.SSL support when OpenSearch Dashboards SSL is enabled.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
#1164
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr