Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove native realm from code base #1307

Merged
merged 1 commit into from
Mar 3, 2022
Merged

remove native realm from code base #1307

merged 1 commit into from
Mar 3, 2022

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Mar 2, 2022 •
edited by kavilla
Loading

Description

Native realm is not supported by current nodejs client.
This will solve nodejs client integration issue.

Partically Resolved:#837

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@ananzh
remove native realm from code base
8eb353e 
Native realm is not supported by current nodejs client.
This will solve nodejs client integration issue.

Partically Resolved:opensearch-project#837

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh requested review from tmarkley and kavilla March 2, 2022 21:07
@ananzh ananzh requested a review from a team as a code owner March 2, 2022 21:07
@ananzh ananzh self-assigned this Mar 2, 2022
@ananzh ananzh added bug Something isn't working xpack-cleanup labels Mar 2, 2022
@ananzh ananzh mentioned this pull request Mar 2, 2022
Closed
7 tasks
kavilla
kavilla approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@ananzh ananzh merged commit 8951429 into opensearch-project:main Mar 3, 2022
Tengda-He pushed a commit to Tengda-He/OpenSearch-Dashboards that referenced this pull request Mar 3, 2022
@ananzh @Tengda-He
remove native realm from code base (opensearch-project#1307)
511e2cf 
Native realm is not supported by current nodejs client.
This will solve nodejs client integration issue.

Partically Resolved:opensearch-project#837

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh deleted the remove-native-realm branch September 18, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@tmarkley tmarkley tmarkley approved these changes

Assignees

@ananzh ananzh

Labels
bug Something isn't working xpack-cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ananzh @tmarkley @kavilla