Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] unit test for config was failing #1261

Merged
merged 1 commit into from
Feb 21, 2022
Merged

[Tests] unit test for config was failing #1261

merged 1 commit into from
Feb 21, 2022

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Feb 18, 2022 •
edited
Loading

Description

openseasrch_config.test.ts was failing with yarn test:jest

Introduced:
#1234

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@kavilla
[Tests] unit test for config was failing
47e857e 
openseasrch_config.test.ts was failing with yarn test:jest

Introduced:
opensearch-project#1234

Issue resolved:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla requested a review from a team as a code owner February 18, 2022 08:40
tmarkley
tmarkley approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is a weird one. It seems like there's an underlying breaking change between graceful-fs v4.2.4 and v4.2.9. Definitely a dependency that we should get rid of in the future.

@kavilla kavilla merged commit 18f8f13 into opensearch-project:main Feb 21, 2022
@kavilla kavilla deleted the avillk/fix_graceful branch February 21, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@tmarkley tmarkley tmarkley approved these changes

@boktorbb boktorbb Awaiting requested review from boktorbb

Assignees
No one assigned
Labels
test:unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kavilla @tmarkley @ananzh