Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Compatibility check prevents Elasticsearch backend #720

Closed
drewrutl opened this issue Aug 13, 2021 · 3 comments · Fixed by #724
Closed

[Enhancement] Compatibility check prevents Elasticsearch backend #720

drewrutl opened this issue Aug 13, 2021 · 3 comments · Fixed by #724
Labels
enhancement New feature or request

Comments

@drewrutl
Copy link

Describe the bug

It's probably not an intended use case, but it seems like compatibility checks comparing Elasticsearch/Kibana versions (and Opensearch/OS-Dashboards) prevent the use of Elasticsearch with Opensearch-Dashboards. I was attempting to use an existing Amazon Elasticsearch Service cluster as the backend for an on-prem Opensearch Dashboard, trying to follow the instructions for connecting a local Kibana instance to Amazon ES found here: https://docs.aws.amazon.com/elasticsearch-service/latest/developerguide/es-kibana.html#es-kibana-local

However, when attempting to start the dashboard service with this set as the backend in the config file, I received this error:
[error][savedobjects-service] This version of OpenSearch Dashboards (v1.0.0) is incompatible with the following OpenSearch nodes in your cluster: v7.10.2 @ undefined (undefined)

I assume this could be related to the old version compatibility matrix for ES/Kibana where major version differences are incompatible - https://github.com/elastic/kibana#version-compatibility-with-elasticsearch

To Reproduce
Steps to reproduce the behavior:
Configure the backend for Opensearch Dashboards to point to any Amazon ES instance or Elasticsearch instance using Elastic's versioning scheme

Expected behavior
If this is at all considered a supported configuration, logic to differentiate between Elasticsearch and OpenSearch version numbers, or a flag to ignore compatibility checks, should allow this to work.

OpenSearch Version
Elasticsearch 7.10.2 (Amazon ES)

Dashboards Version
1.0.0

Plugins

N/A

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: Amazon Linux 2
@drewrutl drewrutl added bug Something isn't working untriaged labels Aug 13, 2021
@kavilla
Copy link
Member

kavilla commented Aug 13, 2021

Hey @drewrutl!

Yeah there is logic to prevent major version differences because the data might have changed and this could create corrupted data. But for OSD 1.0.0 we specifically reverted any data changes so technically it should work with OS 1.0.0 or ES 7.10.2

My proposal is that if and only if OSD is 1.0.0 and the engines are on version 7.10.2 or 1.0.0 then the application can start. We shouldn't consider making it supported configuration to prevent any future corruptions in data if we do end up planning on changing the data.

What do people think?

@dblock
Copy link
Member

dblock commented Aug 16, 2021

What do people think?

If we can make sure integration tests run on such a configuration, why not.

kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Aug 17, 2021
Enables the version check to work specifically in the case of OSD 1.X and
legacy 7.10.2. This will avoid conflicts in future versions of the application
where Dashboards is not compatible with the Engines on version differences.

Testing for verifying compatible legacy version.

Issues resolved:
opensearch-project#720

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla removed the untriaged label Aug 17, 2021
@kavilla kavilla linked a pull request Aug 17, 2021 that will close this issue
5 tasks
@kavilla kavilla changed the title [BUG] Compatibility check prevents Elasticsearch backend [Enhancement] Compatibility check prevents Elasticsearch backend Aug 18, 2021
@kavilla kavilla added enhancement New feature or request and removed bug Something isn't working labels Aug 18, 2021
@kavilla
Copy link
Member

kavilla commented Aug 18, 2021

Updated to make it an enhancement since this wasn't intended functionality. But for sake being more inviting we will do this.

kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Aug 18, 2021
Enables the version check to work specifically in the case of OSD 1.X and
legacy 7.10.2. This will avoid conflicts in future versions of the application
where Dashboards is not compatible with the Engines on version differences.

Testing for verifying compatible legacy version.

Issues resolved:
opensearch-project#720

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this issue Aug 24, 2021
Enables the version check to work specifically in the case of OSD 1.X and
legacy 7.10.2. This will avoid conflicts in future versions of the application
where Dashboards is not compatible with the Engines on version differences.

Testing for verifying compatible legacy version.

Issues resolved:
#720

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Aug 24, 2021
Enables the version check to work specifically in the case of OSD 1.X and
legacy 7.10.2. This will avoid conflicts in future versions of the application
where Dashboards is not compatible with the Engines on version differences.

Testing for verifying compatible legacy version.

Issues resolved:
opensearch-project#720

Backport PR:
opensearch-project#724

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this issue Aug 27, 2021
Enables the version check to work specifically in the case of OSD 1.X and
legacy 7.10.2. This will avoid conflicts in future versions of the application
where Dashboards is not compatible with the Engines on version differences.

Testing for verifying compatible legacy version.

Issues resolved:
#720

Backport PR:
#724

Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants