Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover-Next][UI] Query editor run button #7040

Closed
Tracked by #6957
kavilla opened this issue Jun 16, 2024 · 0 comments
Closed
Tracked by #6957

[Discover-Next][UI] Query editor run button #7040

kavilla opened this issue Jun 16, 2024 · 0 comments

Comments

@kavilla
Copy link
Member

kavilla commented Jun 16, 2024

Description:

Currently the query editor submit button says: Refresh. It should have a play button and say Run like:

Screenshot 2024-06-15 at 6 55 44 PM

Requirements:

  • UX questions:
    • Does the submit button show cancel if the request is running? The cancel then can abort the request and/or send the abort signal to any long running processes on the engine side? Related to the first query of async queries before a session ID is retrieved
    • Does this get displayed in collapsed mode [Discover-Next][UI] Query editor can be collapsed #7038?
  • Fix issue with OUI bug???
    • The current button is using OuiSuperUpdateButton [SOURCE]
    • It should be respecting the prop children or just adding a child element and it is display instead of the text. But it wasn't working for me so there might be a bug in OUI. Might be worth to fix it in OUI and add some documentation about this button in OUI.
  • Implement
@kavilla kavilla changed the title Run button [Discover-Next][UI] Run button Jun 16, 2024
@kavilla kavilla changed the title [Discover-Next][UI] Run button [Discover-Next][UI] Query editor run button Jun 16, 2024
@kavilla kavilla closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants