Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover-Next][UI] Query editor can be collapsed #7038

Closed
Tracked by #6957
kavilla opened this issue Jun 16, 2024 · 0 comments · Fixed by #7309
Closed
Tracked by #6957

[Discover-Next][UI] Query editor can be collapsed #7038

kavilla opened this issue Jun 16, 2024 · 0 comments · Fixed by #7309
Labels
discover-next ux / ui Improvements or additions to user experience, flows, components, UI elements v2.16.0

Comments

@kavilla
Copy link
Member

kavilla commented Jun 16, 2024

Description

When query enhancements are enabled. Users default see the editor expanded, but users select the arrowDown icon
Screenshot 2024-06-15 at 5 43 55 PM

The query editor should collapse for query string input type of component.

Requirements

  • Get mocks for collapsed view
  • Questions for UX:
    • Confirm we display an ellipsis (...) if query is too long
    • Can users still change the query language in collapsed view?
    • Can users modify the query in the collapsed view? Or when they select/focus the input it automatically expand to the query editor?
    • Dashboards and visualizations will have the default bar. The arrowDown icon is tied to the saved query. If we are making expanding the default. Should we consider removing the icon globally for saved query (regardless of this is toggled on or not)
      • Screenshot 2024-06-15 at 6 09 06 PM
  • Implement
    • Design Consideration: Depending on the mocks, what design proposal could be expanding between the query editor and query string input component. But if there are a lot of differences between query string input and collapsed view then implement a different component.
    • tl;dr: might need a design proposal
  • Tests
@kavilla kavilla changed the title Expand and collapse [Discover-Next][UI] Query editor can be collapsed into a query string input Jun 16, 2024
@kavilla kavilla added ux / ui Improvements or additions to user experience, flows, components, UI elements v2.16.0 discover-next labels Jun 16, 2024
@kavilla kavilla changed the title [Discover-Next][UI] Query editor can be collapsed into a query string input [Discover-Next][UI] Query editor can be collapsed Jun 16, 2024
@kavilla kavilla linked a pull request Jul 18, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discover-next ux / ui Improvements or additions to user experience, flows, components, UI elements v2.16.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant