Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VisBuilder][BUG] Unnecessary and Confusing EuiProgress in Metric and Table Vis when no data #6671

Closed
ananzh opened this issue Apr 29, 2024 · 0 comments
Closed

[VisBuilder][BUG] Unnecessary and Confusing EuiProgress in Metric and Table Vis when no data #6671

ananzh opened this issue Apr 29, 2024 · 0 comments
Assignees
@ananzh
Labels
bug Something isn't working v2.16.0 vis builder

Comments

@ananzh
Copy link
Member

ananzh commented Apr 29, 2024

Describe the bug

See an Unnecessary and Confusing EuiProgress in Metric and Table. No such issue in vislib vis: bar, line, and area

loading-bug.mov

To Reproduce
See the video

Expected behavior
no EuiProgress

OpenSearch Version
main

Dashboards Version
main
@ananzh ananzh added bug Something isn't working untriaged v2.14.0 vis builder and removed untriaged labels Apr 29, 2024
@ananzh ananzh self-assigned this Apr 29, 2024
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 29, 2024
@ananzh
[VisBuilder][BUG] Flat render structure in Metric and Table Vis
c2aaba9 
This issue is caused by the callback behavior in ReactExpressionRenderer. The callback
to ReactExpressionRenderer to update isloading state is lost if we wrap the render
vis with VisualizationContainer.

This PR moved VisualizationContainer directly in MetricVisComponent. When put
VisualizationContainer directly in the MetricVisComponent, all the lifecycle methods
and hooks within MetricVisComponent directly influence the rendering of VisualizationContainer.
This means that calls to renderComplete and other lifecycle integrations are more directly managed.

Issue Resolved:
opensearch-project#6671

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh mentioned this issue Apr 29, 2024
Merged
7 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Apr 29, 2024
@ananzh
[VisBuilder][BUG] Flat render structure in Metric and Table Vis
c4368c2 
This issue is caused by the callback behavior in ReactExpressionRenderer. The callback
to ReactExpressionRenderer to update isloading state is lost if we wrap the render
vis with VisualizationContainer.

This PR moved VisualizationContainer directly in MetricVisComponent. When put
VisualizationContainer directly in the MetricVisComponent, all the lifecycle methods
and hooks within MetricVisComponent directly influence the rendering of VisualizationContainer.
This means that calls to renderComplete and other lifecycle integrations are more directly managed.

Issue Resolved:
opensearch-project#6671

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh added v2.15.0 and removed v2.14.0 labels May 4, 2024
@ananzh ananzh added v2.16.0 and removed v2.15.0 labels Jun 7, 2024
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jul 12, 2024
@ananzh
[VisBuilder][BUG] Flat render structure in Metric and Table Vis
9f84c8b 
This issue is caused by the callback behavior in ReactExpressionRenderer. The callback
to ReactExpressionRenderer to update isloading state is lost if we wrap the render
vis with VisualizationContainer.

This PR moved VisualizationContainer directly in MetricVisComponent. When put
VisualizationContainer directly in the MetricVisComponent, all the lifecycle methods
and hooks within MetricVisComponent directly influence the rendering of VisualizationContainer.
This means that calls to renderComplete and other lifecycle integrations are more directly managed.

Issue Resolved:
opensearch-project#6671

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jul 12, 2024
@ananzh
[VisBuilder][BUG] Flat render structure in Metric and Table Vis
0491f9f 
This issue is caused by the callback behavior in ReactExpressionRenderer. The callback
to ReactExpressionRenderer to update isloading state is lost if we wrap the render
vis with VisualizationContainer.

This PR moved VisualizationContainer directly in MetricVisComponent. When put
VisualizationContainer directly in the MetricVisComponent, all the lifecycle methods
and hooks within MetricVisComponent directly influence the rendering of VisualizationContainer.
This means that calls to renderComplete and other lifecycle integrations are more directly managed.

Issue Resolved:
opensearch-project#6671

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jul 23, 2024
@ananzh
[VisBuilder][BUG] Flat render structure in Metric and Table Vis
9d8bca7 
This issue is caused by the callback behavior in ReactExpressionRenderer. The callback
to ReactExpressionRenderer to update isloading state is lost if we wrap the render
vis with VisualizationContainer.

This PR moved VisualizationContainer directly in MetricVisComponent. When put
VisualizationContainer directly in the MetricVisComponent, all the lifecycle methods
and hooks within MetricVisComponent directly influence the rendering of VisualizationContainer.
This means that calls to renderComplete and other lifecycle integrations are more directly managed.

Issue Resolved:
opensearch-project#6671

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jul 24, 2024
@ananzh
[VisBuilder][BUG] Flat render structure in Metric and Table Vis
30e3a76 
This issue is caused by the callback behavior in ReactExpressionRenderer. The callback
to ReactExpressionRenderer to update isloading state is lost if we wrap the render
vis with VisualizationContainer.

This PR moved VisualizationContainer directly in MetricVisComponent. When put
VisualizationContainer directly in the MetricVisComponent, all the lifecycle methods
and hooks within MetricVisComponent directly influence the rendering of VisualizationContainer.
This means that calls to renderComplete and other lifecycle integrations are more directly managed.

Issue Resolved:
opensearch-project#6671

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jul 24, 2024
@ananzh
[VisBuilder][BUG] Flat render structure in Metric and Table Vis
75ec242 
This issue is caused by the callback behavior in ReactExpressionRenderer. The callback
to ReactExpressionRenderer to update isloading state is lost if we wrap the render
vis with VisualizationContainer.

This PR moved VisualizationContainer directly in MetricVisComponent. When put
VisualizationContainer directly in the MetricVisComponent, all the lifecycle methods
and hooks within MetricVisComponent directly influence the rendering of VisualizationContainer.
This means that calls to renderComplete and other lifecycle integrations are more directly managed.

Issue Resolved:
opensearch-project#6671

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh closed this as completed in 83317a2 Jul 24, 2024
opensearch-trigger-bot bot pushed a commit that referenced this issue Jul 24, 2024
@github-actions @opensearch-changeset-bot
[VisBuilder][BUG] Flat render structure in Metric and Table Vis (#6674)
31bfd51 
* [VisBuilder][BUG] Flat render structure in Metric and Table Vis

This issue is caused by the callback behavior in ReactExpressionRenderer. The callback
to ReactExpressionRenderer to update isloading state is lost if we wrap the render
vis with VisualizationContainer.

This PR moved VisualizationContainer directly in MetricVisComponent. When put
VisualizationContainer directly in the MetricVisComponent, all the lifecycle methods
and hooks within MetricVisComponent directly influence the rendering of VisualizationContainer.
This means that calls to renderComplete and other lifecycle integrations are more directly managed.

Issue Resolved:
#6671

Signed-off-by: Anan Zhuang <[email protected]>

* Changeset file for PR #6674 created/updated

---------

Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 83317a2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jul 24, 2024
@github-actions @opensearch-changeset-bot
[VisBuilder][BUG] Flat render structure in Metric and Table Vis (#6674)
3f18e95 
* [VisBuilder][BUG] Flat render structure in Metric and Table Vis

This issue is caused by the callback behavior in ReactExpressionRenderer. The callback
to ReactExpressionRenderer to update isloading state is lost if we wrap the render
vis with VisualizationContainer.

This PR moved VisualizationContainer directly in MetricVisComponent. When put
VisualizationContainer directly in the MetricVisComponent, all the lifecycle methods
and hooks within MetricVisComponent directly influence the rendering of VisualizationContainer.
This means that calls to renderComplete and other lifecycle integrations are more directly managed.

Issue Resolved:
#6671

Signed-off-by: Anan Zhuang <[email protected]>

* Changeset file for PR #6674 created/updated

---------

Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 83317a2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27 pushed a commit that referenced this issue Jul 24, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[VisBuilder][BUG] Flat render structure in Metric and Table Vis (#6674)…
98caa31 
… (#7447)

* [VisBuilder][BUG] Flat render structure in Metric and Table Vis

This issue is caused by the callback behavior in ReactExpressionRenderer. The callback
to ReactExpressionRenderer to update isloading state is lost if we wrap the render
vis with VisualizationContainer.

This PR moved VisualizationContainer directly in MetricVisComponent. When put
VisualizationContainer directly in the MetricVisComponent, all the lifecycle methods
and hooks within MetricVisComponent directly influence the rendering of VisualizationContainer.
This means that calls to renderComplete and other lifecycle integrations are more directly managed.

Issue Resolved:
#6671



* Changeset file for PR #6674 created/updated

---------



(cherry picked from commit 83317a2)

Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ananzh added a commit that referenced this issue Jul 24, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @ananzh
[VisBuilder][BUG] Flat render structure in Metric and Table Vis (#6674)…
812a9e9 
… (#7448)

* [VisBuilder][BUG] Flat render structure in Metric and Table Vis

This issue is caused by the callback behavior in ReactExpressionRenderer. The callback
to ReactExpressionRenderer to update isloading state is lost if we wrap the render
vis with VisualizationContainer.

This PR moved VisualizationContainer directly in MetricVisComponent. When put
VisualizationContainer directly in the MetricVisComponent, all the lifecycle methods
and hooks within MetricVisComponent directly influence the rendering of VisualizationContainer.
This means that calls to renderComplete and other lifecycle integrations are more directly managed.

Issue Resolved:
#6671



* Changeset file for PR #6674 created/updated

---------



(cherry picked from commit 83317a2)

Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Anan Zhuang <[email protected]>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this issue Aug 1, 2024
@ananzh @opensearch-changeset-bot @Qxisylolo
[VisBuilder][BUG] Flat render structure in Metric and Table Vis (open…
582d90f 
…search-project#6674)

* [VisBuilder][BUG] Flat render structure in Metric and Table Vis

This issue is caused by the callback behavior in ReactExpressionRenderer. The callback
to ReactExpressionRenderer to update isloading state is lost if we wrap the render
vis with VisualizationContainer.

This PR moved VisualizationContainer directly in MetricVisComponent. When put
VisualizationContainer directly in the MetricVisComponent, all the lifecycle methods
and hooks within MetricVisComponent directly influence the rendering of VisualizationContainer.
This means that calls to renderComplete and other lifecycle integrations are more directly managed.

Issue Resolved:
opensearch-project#6671

Signed-off-by: Anan Zhuang <[email protected]>

* Changeset file for PR opensearch-project#6674 created/updated

---------

Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
bug Something isn't working v2.16.0 vis builder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ananzh