Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Anywhere] Collect VisLayers when rendering visualization line charts #3122

Closed
ohltyler opened this issue Dec 22, 2022 · 2 comments · Fixed by #3131
Closed

[Feature Anywhere] Collect VisLayers when rendering visualization line charts #3122

ohltyler opened this issue Dec 22, 2022 · 2 comments · Fixed by #3131
Labels
feature-anywhere visualizations Issues and PRs related to visualizations

Comments

@ohltyler
Copy link
Member

ohltyler commented Dec 22, 2022

As part of #2880, we will need to inject logic in the visualization render flow to fetch and render any associated VisLayers on the chart.
Breaking this into steps, this would look like:

  1. Determine whether a given vis is eligible to render VisLayers (e.g., of type line, valid axes configs)
  2. Fetch all augment-vis saved objects that reference this particular vis
  3. Construct a pipeline of expressions functions using the specified name & args listed in the saved object(s)
  4. Execute the pipeline to collect a set of VisLayers

The process for parsing the collected VisLayers and actually updating the chart canvas is tracked in #3130.

@ohltyler ohltyler added visualizations Issues and PRs related to visualizations feature-anywhere v2.6.0 labels Dec 22, 2022
@ohltyler ohltyler changed the title [Feature Anywhere] Process VisLayers for line chart visualizations [Feature Anywhere] Process VisLayers for line chart visualizations Dec 22, 2022
@ohltyler ohltyler changed the title [Feature Anywhere] Process VisLayers for line chart visualizations [Feature Anywhere] Collect VisLayers when rendering visualization line charts Dec 23, 2022
@ohltyler
Copy link
Member Author

ohltyler commented Feb 9, 2023

Eligibility will be handled separately as part of #3268

@joshuarrrr joshuarrrr removed the v2.6.0 label Feb 17, 2023
@ohltyler
Copy link
Member Author

ohltyler commented Mar 9, 2023

#3131 has merged

@ohltyler ohltyler closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-anywhere visualizations Issues and PRs related to visualizations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants