Remove update snapshot on .github/pr_check_workflow.yml #278
Labels
enhancement
New feature or request
Comments
|
Removed we need to deep dive the test failures. |
yubonluo
added a commit
to yubonluo/OpenSearch-Dashboards
that referenced
this issue
Mar 6, 2024
* remove management workspace * delete unnecessary code comments * delete comments # Conflicts: # src/core/public/index.ts # src/core/public/utils/index.ts # src/core/utils/constants.ts # src/plugins/workspace/public/components/workspace_creator/workspace_form.tsx # src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx # src/plugins/workspace/server/workspace_client.ts
gaobinlong
pushed a commit
to gaobinlong/OpenSearch-Dashboards
that referenced
this issue
Mar 7, 2024
* remove management workspace * delete unnecessary code comments * delete comments
raintygao
pushed a commit
to raintygao/OpenSearch-Dashboards
that referenced
this issue
Mar 8, 2024
…ect#281) * remove management workspace (opensearch-project#278) * remove management workspace * delete unnecessary code comments * delete comments # Conflicts: # src/core/public/index.ts # src/core/public/utils/index.ts # src/core/utils/constants.ts # src/plugins/workspace/public/components/workspace_creator/workspace_form.tsx # src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx # src/plugins/workspace/server/workspace_client.ts * update typescript version to 4.6.4 * delete useless code and add a lost yarn.lock * delete yarn.lock
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this issue
Mar 18, 2024
…ect#281) * remove management workspace (opensearch-project#278) * remove management workspace * delete unnecessary code comments * delete comments # Conflicts: # src/core/public/index.ts # src/core/public/utils/index.ts # src/core/utils/constants.ts # src/plugins/workspace/public/components/workspace_creator/workspace_form.tsx # src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx # src/plugins/workspace/server/workspace_client.ts * update typescript version to 4.6.4 * delete useless code and add a lost yarn.lock * delete yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
When adding
yarn test:jestto .github/pr_check_workflow.yml the workflow fails due to out of date snapshots. So we can some tests running we added-uto the workflow so that the snapshots update and the test can pass just like how we did the Jenkins file. But this bad because we should be failing tests if the code author have not updated and committed the snapshots.Describe the solution you'd like
Figure out why
yarn test:jestis failing, fix it, and remove the-uto update snapshots in the CI.Describe alternatives you've considered
n/a
Additional context
n/a
The text was updated successfully, but these errors were encountered: