Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table Visualization] Research and add error handling #2651

Open
ananzh opened this issue Oct 22, 2022 · 1 comment
Open

[Table Visualization] Research and add error handling #2651

ananzh opened this issue Oct 22, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Community development is encouraged tableVis table visualization visualizations Issues and PRs related to visualizations

Comments

@ananzh
Copy link
Member

ananzh commented Oct 22, 2022

Currently, we don't have any error handling for the new table vis. This might be an issue, for example:

handlers.uiState.set('vis.columnsWidth', nextState);
handlers.uiState.emit('reload');

We need some error handling for the case that handlers.uiState is undefined. Maybe it's something we want to fail earlier on or else wait for.

@ananzh
Copy link
Member Author

ananzh commented Oct 25, 2022

Will work on this after 1) hookup table to vis builder and 2) add tests

@ananzh ananzh added tableVis table visualization visualizations Issues and PRs related to visualizations labels Nov 10, 2022
@ananzh ananzh changed the title [Table Visualization] research and add error handling [Table Visualization] Research and add error handling Nov 10, 2022
@ananzh ananzh added good first issue Good for newcomers help wanted Community development is encouraged labels Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Community development is encouraged tableVis table visualization visualizations Issues and PRs related to visualizations
Projects
None yet
Development

No branches or pull requests

1 participant