Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table Visualization][research][enhancement] local state management (sort and resize) #2550

Closed
ananzh opened this issue Oct 11, 2022 · 1 comment
Assignees
Labels
research tableVis table visualization

Comments

@ananzh
Copy link
Member

ananzh commented Oct 11, 2022

Regarding this feedback (#2502 (comment) ), we are using extra local states for column sort and resize. uiState.set from PersistedState won’t let me to render the component. If I switch setSortColumn(updatedVisState.sortColumn); to uiState.set then it won’t re-render with corrected sorted columns.

I am using an example from charts (https://github.com/opensearch-project/OpenSearch-Dashboards/blob/d7004dc5b0392477f[…]3b/src/plugins/charts/public/static/components/color_schema.tsx ) to force it work.

Regarding this part, I open this issue as a post research & enhancement topic. There are couple of things we need to research and discussion:

  • simply local state
  • why uiState.set won't re-render
@ananzh ananzh added bug Something isn't working untriaged tableVis table visualization and removed bug Something isn't working untriaged labels Oct 11, 2022
@ananzh ananzh self-assigned this Oct 11, 2022
@ananzh
Copy link
Member Author

ananzh commented Nov 7, 2022

table vis could use uiState. see current feature/tableVis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
research tableVis table visualization
Projects
None yet
Development

No branches or pull requests

1 participant