Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Maps showRegionBlockedConfig doesn't work #2041

Closed
kavilla opened this issue Aug 2, 2022 · 0 comments · Fixed by #2042
Closed

[BUG] Maps showRegionBlockedConfig doesn't work #2041

kavilla opened this issue Aug 2, 2022 · 0 comments · Fixed by #2042
Labels
bug Something isn't working maps Issues or PRs related to the Maps Service v2.2.0

Comments

@kavilla
Copy link
Member

kavilla commented Aug 2, 2022

Set config in opensearch_dashboards.yml value was not getting passed down to the maps plugins.
@kavilla kavilla added bug Something isn't working untriaged labels Aug 2, 2022
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Aug 2, 2022
@kavilla
[BUG] show region blocked warning config not respected
b2021a7 
The configuration wasn't passed down to the options that was
expecting it to be available for the plugin to run the conditional
logic.

Value was undefined for region map. Also, cleaned up the vega map
view code.

Issue:

opensearch-project#2041

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla mentioned this issue Aug 2, 2022
Merged
7 tasks
@kavilla kavilla added v2.2.0 maps Issues or PRs related to the Maps Service and removed untriaged labels Aug 2, 2022
@kavilla kavilla linked a pull request Aug 2, 2022 that will close this issue
[BUG] show region blocked warning config not respected #2042
Merged
7 tasks
kavilla added a commit that referenced this issue Aug 2, 2022
@kavilla
[BUG] show region blocked warning config not respected (#2042)
5fb4143 
The configuration wasn't passed down to the options that was
expecting it to be available for the plugin to run the conditional
logic.

Value was undefined for region map. Also, cleaned up the vega map
view code.

Issue:

#2041

Signed-off-by: Kawika Avilla <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Aug 2, 2022
@kavilla @github-actions
[BUG] show region blocked warning config not respected (#2042)
d03f16a 
The configuration wasn't passed down to the options that was
expecting it to be available for the plugin to run the conditional
logic.

Value was undefined for region map. Also, cleaned up the vega map
view code.

Issue:

#2041

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 5fb4143)
kavilla added a commit that referenced this issue Aug 3, 2022
@opensearch-trigger-bot @kavilla
[BUG] show region blocked warning config not respected (#2042) (#2058)
0240c73 
The configuration wasn't passed down to the options that was
expecting it to be available for the plugin to run the conditional
logic.

Value was undefined for region map. Also, cleaned up the vega map
view code.

Issue:

#2041

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 5fb4143)

Co-authored-by: Kawika Avilla <[email protected]>
CPTNB pushed a commit to CPTNB/OpenSearch-Dashboards that referenced this issue Aug 8, 2022
@kavilla @CPTNB
[BUG] show region blocked warning config not respected (opensearch-pr…
112529d 
…oject#2042)

The configuration wasn't passed down to the options that was
expecting it to be available for the plugin to run the conditional
logic.

Value was undefined for region map. Also, cleaned up the vega map
view code.

Issue:

opensearch-project#2041

Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working maps Issues or PRs related to the Maps Service v2.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] show region blocked warning config not respected kavilla/OpenSearch-Dashboards-1
1 participant
@kavilla