Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PURIFY] Ensure all test cases are passing #2

Closed
4 tasks done
mihirsoni opened this issue Jan 29, 2021 · 1 comment
Closed
4 tasks done

[PURIFY] Ensure all test cases are passing #2

mihirsoni opened this issue Jan 29, 2021 · 1 comment
Assignees

Comments

@mihirsoni
Copy link
Contributor

mihirsoni commented Jan 29, 2021

  • Unit test cases
  • Integration tests
  • Mocha tests
  • Functional test.
@mihirsoni
Copy link
Contributor Author

Closing this as the main was able to successfully run all tests.

@mihirsoni mihirsoni self-assigned this Mar 21, 2021
ashwin-pc added a commit that referenced this issue Feb 22, 2024
…ct (#5718)

* updating change set .yml template file according what agreed last meeting

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add 'Changelog' section to PR template

Signed-off-by: Johnathon Bowers <[email protected]>

* adding dummy change set files for work in release notes script

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* adding dummy change set files for work in release notes script

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* creating 'create_change_set_worflow.yml' file - starting version

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* commenting Build and Test worflow and correcting name for Create Change Set worflow

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* commenting Build and Test worflow and correcting name for Create Change Set worflow

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* uncommenting Build and Test workflow

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #2

* removing dummy changesets

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #2

* Add changeset for PR #2

* updating pull_request_template.md for changelog entries

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* removing old changeset with wrong format

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #2

* adding change sets dummy files 1.yml, 3.yml and 4.yml

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #2

* fix a line in changeset 2.yml file, add scripting for updating the changelog.md and generate a opensearch-dashboards.release-notes-pkgVersion.md when we make a release, have not implemented deleting all the changeset files in the script

Signed-off-by: Qiwen Li <[email protected]>

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Bump actions/checkout from v2 to v4

Signed-off-by: Johnathon Bowers <[email protected]>

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* release note script refactor + deletes fragment

added the deletiong of fragment files at the end.
Did minor refactoring/cleanup

Signed-off-by: CMDWillYang <[email protected]>

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Update language in 'Changelog' section of PR template

Signed-off-by: Johnathon Bowers <[email protected]>

* Add changeset for PR #2

* Add changeset for PR #2

* Update src/dev/generate_release_note.ts

Co-authored-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Qiwen Li <[email protected]>

* Add changeset for PR #2

* Add first draft of changelog process README

Signed-off-by: Johnathon Bowers <[email protected]>

* Add changeset for PR #2

* changed error handling behaviors.

Signed-off-by: CMDWillYang <[email protected]>

* Add changeset for PR #2

* Add more details to changelog README

Signed-off-by: Johnathon Bowers <[email protected]>

* Add changeset for PR #2

* added error

Signed-off-by: qiwen li <[email protected]>

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Abbreviate README and link to workflow README

Signed-off-by: Johnathon Bowers <[email protected]>

* Add changeset for PR #2

* Add changeset for PR #2

* deleting test.txt file used to test if other contributors of project were able to push updates to this branch

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #2

* fixing formatting in create_change_set_workflow.yml file

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* updating title for README.md in changelogs directory

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* updating description of README.md in changelogs directory

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* removing demo fragments and adding new single one specifiying new feat of Changelog and Release Notes projects in this PR

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #2

* removing demo fragment 2.yml

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #2

* removed fragment thats too long. added helper file, used async functions, and added validation.

Signed-off-by: CMDWillYang <[email protected]>

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* adding 5519.yml fragment file and removing 2.yml dummy fragment file

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* updating changeset worflow removing syncronize option

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* deleting 5519.yml fragment file (now will be generated by workflow)

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #2

* Add changeset for PR #2

* removing 2.yml fragment dummy file

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #2

* Add changeset for PR #2

* removing 2.yml fragment dummy file

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* refactored code (deleteFragments, readFragments returns sections and paths)

Signed-off-by: CMDWillYang <[email protected]>

* Add changeset for PR #2

* removing 2.yml fragment dummy file

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* moved deleteFragment to end of script

Signed-off-by: CMDWillYang <[email protected]>

* removing changelog_verifier.yml

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* changed max_length to 100

Signed-off-by: CMDWillYang <[email protected]>

* Add changeset for PR #2

* Add changeset for PR #2

* adding write permissions to for changeset workflow

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* removing 2.yml fragment dummy file

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* adding write permissions to for changeset workflow

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* adding write permissions to for changeset workflow

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* refactored code/main function, now move fragment to temp folder.

Signed-off-by: CMDWillYang <[email protected]>

* Add test.txt

Signed-off-by: Johnathon Bowers <[email protected]>

* Remove test.txt

Signed-off-by: Johnathon Bowers <[email protected]>

* updating token name for workflow

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* update token name

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* Add changeset for PR #2

* updating changeset workflow by giving correct reference for checkout action

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* updating changeset workflow by removing reference for checkout action

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* updating github action event from pull_request to pull_request_target

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #19

* deleting fragment 19.yml

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* adding CHANGESET_TOKEN and related logic

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* changing event pull_request_target to pull_request

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #25

* changing event pull_request to pull_request_target

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add changeset for PR #24

* Add changeset for PR #24

* update changeset file 25.yml for PR #25

* update changeset file 25.yml for PR #25

* update changeset file 25.yml for PR #25

* update changeset file 25.yml for PR #25

* update changeset file 25.yml for PR #25

* update changeset file 25.yml for PR #25

* update changeset file 25.yml for PR #25

* update changeset file 25.yml for PR #25

* deleting workflow file for creating changeset files

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* update changeset file 25.yml for PR #25

* update changeset file 25.yml for PR #25

* removing fragment files

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* create changeset file 25.yml for PR #25

* update changeset file 25.yml for PR #25

* update changeset file 25.yml for PR #25

* update changeset file 25.yml for PR #25

* update changeset file 25.yml for PR #25

* update file 25.yml for PR #25

* update file 25.yml for PR #25

* test:
- Data ([#29](BigSamu#29))
- Data2 ([#29](BigSamu#29))

* create file 29.yml for PR #29

* test:
- Data ([#29](BigSamu#29))
- Data 2 ([#29](BigSamu#29))

* changeset file for PR #29 updated

* changeset file for PR #29 updated

* changeset file for PR #29 updated

* changeset file for PR #29 updated

* changeset file for PR #29 updated

* changeset file for PR #29 updated

* changeset file for PR #29 updated

* changeset file for PR #29 updated

* changeset file for PR #29 updated

* changeset file for PR #29 deleted

* changeset file for PR #29 created

* changeset file for PR #29 updated

* changeset file for PR #29 deleted

* changeset file for PR #29 created

* changeset file for PR #29 deleted

* changeset file for PR #29 created

* changeset file for PR #29 updated

* changeset file for PR #29 updated

* changeset file for PR #29 updated

* changeset file for PR #29 updated

* Changeset file for PR #29 updated

* Changeset file for PR #29 deleted

* Changeset file for PR #29 created

* Changeset file for PR #29 deleted

* Changeset file for PR #29 created

* Changeset file for PR #29 updated

* Changeset file for PR #29 updated

* Changeset file for PR #29 updated

* Changeset file for PR #29 updated

* Changeset file for PR #29 updated

* Changeset file for PR #29 deleted

* Changeset file for PR #29 created

* Changeset file for PR #29 deleted

* adding parse_changelog_workflow.yml file

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* updating permissions for parse changelog workflow

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* updating permissions for parse chaneglog action

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* updating permissions for parse chaneglog action

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* updating permissions for parse chaneglog action

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* updating permissions for parse chaneglog action

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* changing name of changelog action file

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* removing dummy fragment file '25.yml'

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* updating name of workflow in opensearch_changelog_workflow.yml file

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* addin dummy file

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* removing dummy file

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Add input secrets to be used in workflow runs

Signed-off-by: Johnathon Bowers <[email protected]>

* updating input variables for opensearch chnagelog workflow

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* updating location reusable workflow

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* changing branch for reusable workflow for developing manual checking approach of changesets

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* changing branch for reusable workflow to 'main'

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* changing branch for reusable workflow to 'main'

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* changing branch of chnagelog workflow to 'feat/manual-changesets' for dev purposes

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* removing 'token' input from 'opensearch_changelog_workflow.yml'

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>

* Revert "removing 'token' input from 'opensearch_changelog_workflow.yml'"

This reverts commit 9b1c1a6.

* Update .github/workflows/opensearch_changelog_workflow.yml

Signed-off-by: Ashwin P Chandran <[email protected]>

---------

Signed-off-by: Samuel Valdes Gutierrez <[email protected]>
Signed-off-by: Johnathon Bowers <[email protected]>
Signed-off-by: Qiwen Li <[email protected]>
Signed-off-by: CMDWillYang <[email protected]>
Signed-off-by: qiwen li <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Johnathon Bowers <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Qiwen Li <[email protected]>
Co-authored-by: CMDWillYang <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: autochangeset[bot] <154024398+autochangeset[bot]@users.noreply.github.com>
Co-authored-by: opensearch-bot[bot] <154024398+opensearch-bot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-bot-dev[bot] <154634848+opensearch-bot-dev[bot]@users.noreply.github.com>
yubonluo referenced this issue in yubonluo/OpenSearch-Dashboards Mar 20, 2024
…objects client wrapper (opensearch-project#230)

* feat: add basic workspace saved objects client wrapper

Signed-off-by: Lin Wang <[email protected]>

* feat: add unit test (#2)

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update client wrapper

Signed-off-by: tygao <[email protected]>

* feat: init permission control in workspace plugin

Signed-off-by: Lin Wang <[email protected]>

* Support disable permission check on workspace (opensearch-project#228)

* support disable permission check for workspace

Signed-off-by: Hailong Cui <[email protected]>

* fix typos

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

* feat: add ACLSearchParams consumer in repository (#3)

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: ACLSearchParams missing in search dsl

Signed-off-by: Lin Wang <[email protected]>

* test: add integration test for workspace saved objects client wrapper

Signed-off-by: Lin Wang <[email protected]>

* style: add empty line under license

Signed-off-by: Lin Wang <[email protected]>

* test: enable workspace permission control for integration tests

Signed-off-by: Lin Wang <[email protected]>

* feat: add workspace into includeHiddenTypes (opensearch-project#249)

* feat: add workspace into includeHiddenTypes of client wrapper and permission control client

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: hiddenType side effect

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>

* fix workspace client wrapper integration tests

Signed-off-by: Lin Wang <[email protected]>

* add permissions fields to workspace CRUD APIs

Signed-off-by: Lin Wang <[email protected]>

* Move WorkspacePermissionMode inside workspace plugin

Signed-off-by: Lin Wang <[email protected]>

* Address pr comments

Signed-off-by: Lin Wang <[email protected]>

* Remove ACLSearchParams in public SavedObjectsFindOptions

Signed-off-by: Lin Wang <[email protected]>

* Remove lodash and Add default permissionModes

Signed-off-by: Lin Wang <[email protected]>

* feat: address concerns on ensureRawRequest (#4)

* feat: address concerns on ensureRawRequest

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add check for empty array

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: make find api backward compatible

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>

* Update annotations and  error

Signed-off-by: Lin Wang <[email protected]>

* Add unit tests for worksapce saved objects client wrapper

Signed-off-by: Lin Wang <[email protected]>

* Remove getPrincipalsOfObjects in permission

Signed-off-by: Lin Wang <[email protected]>

* Fix permissionEnabled flag missed in workspace plugin setup test

Signed-off-by: Lin Wang <[email protected]>

* Change back to Not Authorized error

Signed-off-by: Lin Wang <[email protected]>

* Fix unit tests for query_params and plugin setup

Signed-off-by: Lin Wang <[email protected]>

* Fix unittests in workspace server utils

Signed-off-by: Lin Wang <[email protected]>

* feat: add workspacesSearchOperators to decouple ACLSearchParams

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update test cases

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize test cases

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize comment

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: omit defaultSearchOperator in public savedobjetcs client

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: omit workspacesSearchOperator field

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: Lin Wang <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Kapian1234 pushed a commit to Kapian1234/OpenSearch-Dashboards that referenced this issue Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant