Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BWC] Verify impact for type and include_type_name no longer being supported #1290

Closed
kavilla opened this issue Feb 26, 2022 · 4 comments
Closed

Comments

@kavilla
Copy link
Member

kavilla commented Feb 26, 2022

We will need to verify if the removal of the type here: opensearch-project/OpenSearch#2239 has impact to backwards compatibility for OpenSearch Dashboards.

If it doesn't then we can close this issue. If it does, does it require a migration script on startup?

If we it does require a migration script then we will take note of a migration path and any documents to ensure that OpenSearch Dashboards and the compatible OpenSearch. If it's somewhat compatible then we will have to make sure if a legacy version goes from 6.8 to OpenSearch Dashboards does not fail to start. Or we will need to update documents.

If we discover no BWC issues than the commented out code added here: #1289 can be removed.

@kavilla kavilla added bug Something isn't working untriaged test:bwc and removed bug Something isn't working untriaged labels Feb 26, 2022
@dreamer-89
Copy link
Member

Here is the meta issue regarding type removal from OpenSearch engine.
opensearch-project/OpenSearch#1940

A high level changes done as part of type removal
https://gist.github.com/dreamer-89/d76eaf639171e8ab32fa7f8b9d6c93d3

@kavilla
Copy link
Member Author

kavilla commented Mar 9, 2022

Will also now need verify impact of this as well:

opensearch-project/OpenSearch#2397

Removal of include_type_name

@kavilla kavilla changed the title [BWC] Verify impact for type no longer being supported [BWC] Verify impact for type and include_type_name no longer being supported Mar 9, 2022
@dblock
Copy link
Member

dblock commented Apr 18, 2022

Assigning to @kavilla since it's labeled 2.0, just so we don't lose it.

@ahopp ahopp added release and removed v2.0.0 labels Apr 19, 2022
@dreamer-89
Copy link
Member

@kavilla : Is there anything pending here ?

kavilla pushed a commit that referenced this issue Jun 24, 2022
…meout (#1788)

As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories.

Includes updates from generation with the removal of type.

Issues:
#1685
#1290

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jun 24, 2022
…meout (#1788)

As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories.

Includes updates from generation with the removal of type.

Issues:
#1685
#1290

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
(cherry picked from commit c659831)
kavilla pushed a commit that referenced this issue Jun 24, 2022
…meout (#1788) (#1794)

As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories.

Includes updates from generation with the removal of type.

Issues:
#1685
#1290

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
(cherry picked from commit c659831)

Co-authored-by: Manasvini B Suryanarayana <[email protected]>
@kavilla kavilla closed this as completed Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants