Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NodeJS][TS2339] error when hookup nodejs client to dashboards #1121

Closed
ananzh opened this issue Jan 10, 2022 · 0 comments
Closed

[NodeJS][TS2339] error when hookup nodejs client to dashboards #1121

ananzh opened this issue Jan 10, 2022 · 0 comments
Assignees
@ananzh
Labels
nodejs 🍭 issues related to nodejs client v2.0.0

Comments

@ananzh
Copy link
Member

ananzh commented Jan 10, 2022 •
edited
Loading

Describe the bug
See one TS2339 errors when hook up nodejs to dashboards (related issue here ). Details are:

  • mocks.test.ts
src/core/server/opensearch/client/mocks.test.ts:57:25 - error TS2339: Property 'asyncSearch' does not exist on type 'DeeplyMockedKeys<Client>'. 57  expectMocked(client.asyncSearch.get);

To Reproduce
Hook up nodejs client to dashboards using node-14. I have a hooked up branch here. Then after removind node-modules, run yarn osd bootstrap.

Expected behavior
Fix the error.
@ananzh ananzh added v2.0.0 nodejs 🍭 issues related to nodejs client labels Jan 10, 2022
@ananzh ananzh self-assigned this Jan 10, 2022
@kavilla kavilla mentioned this issue Jan 11, 2022
Closed
8 tasks
@ananzh ananzh closed this as completed Jan 26, 2022
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@rshen91 @markov00
feat(a11y): add label for screen readers (opensearch-project#1121)
ddb8782 
Fixes opensearch-project#1096 

BREAKING CHANGE: `description` prop in `<Settings/>` is renamed to `ariaDescription`

Co-authored-by: Marco Vettorello <[email protected]>
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot @markov00
chore(release): 29.0.0 [skip ci]
70e503a 
# [29.0.0](elastic/elastic-charts@v28.2.0...v29.0.0) (2021-04-22)

### Features

* **a11y:** add label for screen readers ([opensearch-project#1121](elastic/elastic-charts#1121)) ([ddb8782](elastic/elastic-charts@ddb8782)), closes [opensearch-project#1096](elastic/elastic-charts#1096)
* **annotations:** marker body with dynamic positioning ([#1116](elastic/elastic-charts#1116)) ([997d487](elastic/elastic-charts@997d487))

### BREAKING CHANGES

* **a11y:** `description` prop in `<Settings/>` is renamed to `ariaDescription`

Co-authored-by: Marco Vettorello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
nodejs 🍭 issues related to nodejs client v2.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ananzh