Fix visAugmenter forming empty key-value pairs in its calls to the …

…`SavedObject` API (#5190) (#5192) Fixes #5187 Signed-off-by: Miki <[email protected]> (cherry picked from commit c27d2f5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]>
opensearch-project · Oct 4, 2023 · f039a55 · f039a55
1 parent 9b1d128
commit f039a55
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/plugins/vis_augmenter/public/utils/utils.test.ts b/src/plugins/vis_augmenter/public/utils/utils.test.ts
@@ -372,12 +372,12 @@ describe('utils', () => {
       expect(loader.findAll).toHaveBeenCalledWith(
         '',
         100,
-        [],
+        undefined,
         {
           type: 'visualization',
           id: visId1 as string,
         },
-        []
+        undefined
       );
     });
     it('single plugin resource is propagated to findAll()', async () => {
@@ -391,7 +391,7 @@ describe('utils', () => {
       expect(loader.findAll).toHaveBeenCalledWith(
         'resource-1',
         100,
-        [],
+        undefined,
         {
           type: 'visualization',
           id: visId1 as string,
@@ -411,7 +411,7 @@ describe('utils', () => {
       expect(loader.findAll).toHaveBeenCalledWith(
         'resource-1|resource-2',
         100,
-        [],
+        undefined,
         {
           type: 'visualization',
           id: visId1 as string,

diff --git a/src/plugins/vis_augmenter/public/utils/utils.ts b/src/plugins/vis_augmenter/public/utils/utils.ts
@@ -72,19 +72,19 @@ export const getAugmentVisSavedObjs = async (
     );
   }
   try {
-    // If there is specified plugin resource IDs, add a search string and search field
-    // into findAll() fn call
+    // If there are any plugin resource IDs specified, add a search string and search field
+    // into findAll() call
     const pluginResourceIdsSpecified =
-      pluginResourceIds !== undefined && pluginResourceIds.length > 0;
+      Array.isArray(pluginResourceIds) && pluginResourceIds.length > 0;
     const resp = await loader?.findAll(
-      pluginResourceIdsSpecified ? pluginResourceIds.join('|') : '',
+      pluginResourceIdsSpecified ? pluginResourceIds!.join('|') : '',
       100,
-      [],
+      undefined,
       {
         type: 'visualization',
         id: visId as string,
       },
-      pluginResourceIdsSpecified ? ['pluginResource.id'] : []
+      pluginResourceIdsSpecified ? ['pluginResource.id'] : undefined
     );
     return (get(resp, 'hits', []) as any[]) as ISavedAugmentVis[];
   } catch (e) {