feat: revert the customized style on nested items

Signed-off-by: SuZhou-Joe <[email protected]>
opensearch-project · Sep 26, 2024 · 9a8bc17 · 9a8bc17
1 parent 8b5186b
commit 9a8bc17
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 28 deletions.
diff --git a/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav_groups.test.tsx.snap b/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav_groups.test.tsx.snap
diff --git a/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.scss b/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.scss
@@ -2,19 +2,14 @@
   border: none !important;
 
   .nav-link-item {
-    padding: $euiSizeXS $euiSize;
+    padding: $euiSizeXS $euiSizeS;
     border-radius: $euiSizeS;
     box-shadow: none;
     margin-bottom: 0;
     margin-top: 0;
 
     .nav-link-item-btn {
       margin-bottom: 0;
-      padding: 0;
-
-      &::after {
-        display: none;
-      }
     }
   }
 
@@ -31,17 +26,6 @@
     padding: $euiSizeS;
   }
 
-  .nav-link-parent-item-button {
-    > span {
-      flex-direction: row-reverse;
-
-      > * {
-        margin-right: $euiSizeS;
-        margin-left: 0;
-      }
-    }
-  }
-
   .nav-link-fake-item {
     margin-top: 0;
   }
@@ -51,15 +35,11 @@
   }
 
   .nav-nested-item {
-    margin-left: -10px;
+    padding: $euiSizeS 0;
 
-    &::after {
-      height: unset;
-    }
-
-    .nav-link-item-btn {
-      padding-left: 0;
-      padding-right: 0;
+    // The height is used to comply with the extra padding
+    &:last-of-type::after {
+      height: 50%;
     }
   }
 

diff --git a/src/core/public/chrome/ui/header/collapsible_nav_groups.tsx b/src/core/public/chrome/ui/header/collapsible_nav_groups.tsx
@@ -110,7 +110,6 @@ export function NavGroups({
         href: undefined,
         onClick: undefined,
         className: classNames(props.className, 'nav-link-parent-item'),
-        buttonClassName: classNames(props.buttonClassName, 'nav-link-parent-item-button'),
         items: navLink.links.map((subNavLink) =>
           createSideNavItem(subNavLink, level + 1, 'nav-nested-item')
         ),