Skip to content

Commit

Permalink
Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests (#…
Browse files Browse the repository at this point in the history
…3976) (#4039)

The latest version of chromedriver is 112.0.1 which does not support
node 14. This PR hardcodes chromedriver to 112.0.0 temporarily. Pls
revert it once we bump to node 18.

Issue Resolved
#3975

Signed-off-by: ananzh <[email protected]>
(cherry picked from commit 5ea0cbe)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
1 parent 97a1ec1 commit 98955c8
Showing 1 changed file with 21 additions and 6 deletions.
27 changes: 21 additions & 6 deletions scripts/upgrade_chromedriver.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,16 +72,31 @@ const versionCheckOutputTokens = (versionCheckOutput || '').match(/(?:^|\s)(9\d|
const majorVersion = Array.isArray(versionCheckOutputTokens) && versionCheckOutputTokens[1];

if (majorVersion) {
let targetVersion = `^${majorVersion}`;

// TODO: Temporary fix to install chromedriver 112.0.0 if major version is 112.
// Exit if major version is greater than 112.
// Revert this once node is bumped to 16+.
// https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3975
if (parseInt(majorVersion) === 112) {
targetVersion = '112.0.0';
} else if (parseInt(majorVersion) > 112) {
console.error(
`::error::Chrome version (${majorVersion}) is not supported by this script. The largest chrome version we support is 112.`
);
process.exit(1);
}

if (process.argv.includes('--install')) {
console.log(`Installing chromedriver@^${majorVersion}`);
console.log(`Installing chromedriver@${targetVersion}`);

spawnSync(`yarn add --dev chromedriver@^${majorVersion}`, {
spawnSync(`yarn add --dev chromedriver@${targetVersion}`, {
stdio: 'inherit',
cwd: process.cwd(),
shell: true,
});
} else {
console.log(`Upgrading to chromedriver@^${majorVersion}`);
console.log(`Upgrading to chromedriver@${targetVersion}`);

let upgraded = false;
const writeStream = createWriteStream('package.json.upgrading-chromedriver', { flags: 'w' });
Expand All @@ -93,7 +108,7 @@ if (majorVersion) {
if (line.includes('"chromedriver": "')) {
line = line.replace(
/"chromedriver":\s*"[~^]?\d[\d.]*\d"/,
`"chromedriver": "^${majorVersion}"`
`"chromedriver": "${targetVersion}"`
);
upgraded = true;
}
Expand All @@ -108,11 +123,11 @@ if (majorVersion) {
renameSync('package.json', 'package.json.bak');
renameSync('package.json.upgrading-chromedriver', 'package.json');

console.log(`Backed up package.json and updated chromedriver to ${majorVersion}`);
console.log(`Backed up package.json and updated chromedriver to ${targetVersion}`);
} else {
unlinkSync('package.json.upgrading-chromedriver');
console.error(
`Failed to update chromedriver to ${majorVersion}. Try adding the \`--install\` switch.`
`Failed to update chromedriver to ${targetVersion}. Try adding the \`--install\` switch.`
);
}
});
Expand Down

0 comments on commit 98955c8

Please sign in to comment.