[i18n] fix generation scripts (#4252)

* [i18n] fix generation scripts Gave file permissions to the i18n scripts Generated: opensearch-project/dashboards-i18n#25 With: ``` ./scripts/use_node scripts/i18n_extract.js --output-dir plugins/dashboards-i18n/translations/ ``` Had to fix some issues generating the scripts for example incorrect namespacing. Issue: #867 Signed-off-by: Kawika Avilla <[email protected]> * update snapshot Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]>
opensearch-project · Jul 28, 2023 · 92507a2 · 92507a2
1 parent 6bab7ef
commit 92507a2
Show file tree

Hide file tree

Showing 13 changed files with 28 additions and 16 deletions.
diff --git a/.i18nrc.json b/.i18nrc.json
@@ -61,11 +61,17 @@
     "visTypeXy": "src/plugins/vis_type_xy",
     "visualizations": "src/plugins/visualizations",
     "visualize": "src/plugins/visualize",
-    "apmOss": "src/plugins/apm_oss",
     "usageCollection": "src/plugins/usage_collection"
   },
   "exclude": [
-    "src/legacy/ui/ui_render/ui_render_mixin.js"
+    "src/legacy/ui/ui_render/ui_render_mixin.js",
+    "src/plugins/home/public/application/components/tutorial",
+    "src/plugins/home/server/tutorials",
+    "src/core/server/rendering/views/template.tsx",
+    "src/plugins/data/public/search/errors/timeout_error.tsx",
+    "src/plugins/home/public/application/components/welcome.tsx",
+    "src/plugins/vis_type_timeline/server/series_functions/graphite.js",
+    "src/plugins/vis_type_timeseries/public/application/components/aggs/serial_diff.js"
   ],
   "translations": []
 }
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -93,6 +93,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 ### 🐛 Bug Fixes
 
+- [Chore] Update deprecated url methods (url.parse(), url.format()) ([#2910](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2910))
+- Cleanup unused url ([#3847](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3847))
+- Fix `i18n` generation scripts ([#4252](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4252))
 - [Saved Objects Management] Fix relationships header overflow ([#4070](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4070))
 - Update main menu to display 'Dashboards' for consistency ([#4453](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4453))
 - [Multiple DataSource] Retain the original sample data API ([#4526](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4526))

diff --git a/scripts/i18n_check.js b/scripts/i18n_check.js
diff --git a/scripts/i18n_extract.js b/scripts/i18n_extract.js
diff --git a/scripts/i18n_integrate.js b/scripts/i18n_integrate.js
diff --git a/src/plugins/dashboard/public/plugin.tsx b/src/plugins/dashboard/public/plugin.tsx
@@ -356,7 +356,7 @@ export class DashboardPlugin
       createSortText: 'Dashboard',
       createLinkText: (
         <FormattedMessage
-          id="opensearch-dashboards-react.tableListView.listing.createNewItemButtonLabel"
+          id="dashboard.tableListView.listing.createNewItemButtonLabel"
           defaultMessage="{entityName}"
           values={{ entityName: 'Dashboard' }}
         />

diff --git a/src/plugins/data/common/search/aggs/buckets/date_range_fn.ts b/src/plugins/data/common/search/aggs/buckets/date_range_fn.ts
@@ -91,7 +91,7 @@ export const aggDateRange = (): FunctionDefinition => ({
     json: {
       types: ['string'],
       help: i18n.translate('data.search.aggs.buckets.dateRange.json.help', {
-        defaultMessage: 'Advanced json to include when the agg is sent to Elasticsearch',
+        defaultMessage: 'Advanced json to include when the agg is sent to OpenSearch',
       }),
     },
     customLabel: {

diff --git a/src/plugins/dev_tools/public/application.tsx b/src/plugins/dev_tools/public/application.tsx
@@ -116,7 +116,7 @@ function DevToolsWrapper({
       })
       .catch(() => {
         toasts.addDanger(
-          i18n.translate('devTool.devToolWrapper.fetchDataSourceError', {
+          i18n.translate('devTools.devToolWrapper.fetchDataSourceError', {
             defaultMessage: 'Unable to fetch existing data sources',
           })
         );
@@ -173,10 +173,10 @@ function DevToolsWrapper({
         {dataSourceEnabled ? (
           <div className="devAppDataSourcePicker">
             <EuiComboBox
-              aria-label={i18n.translate('devTool.devToolWrapper.DataSourceComboBoxAriaLabel', {
+              aria-label={i18n.translate('devTools.devToolWrapper.DataSourceComboBoxAriaLabel', {
                 defaultMessage: 'Select a Data Source',
               })}
-              placeholder={i18n.translate('devTool.devToolWrapper.DataSourceComboBoxPlaceholder', {
+              placeholder={i18n.translate('devTools.devToolWrapper.DataSourceComboBoxPlaceholder', {
                 defaultMessage: 'Select a Data Source',
               })}
               singleSelection={{ asPlainText: true }}

diff --git a/src/plugins/expressions/common/expression_functions/specs/opensearch_dashboards.ts b/src/plugins/expressions/common/expression_functions/specs/opensearch_dashboards.ts
@@ -49,8 +49,8 @@ export const opensearchDashboards: ExpressionFunctionOpenSearchDashboards = {
 
   inputTypes: ['opensearch_dashboards_context', 'null'],
 
-  help: i18n.translate('expressions.functions.kibana.help', {
-    defaultMessage: 'Gets opensearch dashboards global context',
+  help: i18n.translate('expressions.functions.opensearchDashboards.help', {
+    defaultMessage: 'Gets OpenSearch Dashboards global context',
   }),
 
   args: {},

diff --git a/...earch_dashboards_overview/public/components/overview/__snapshots__/overview.test.tsx.snap b/...earch_dashboards_overview/public/components/overview/__snapshots__/overview.test.tsx.snap
diff --git a/src/plugins/opensearch_dashboards_overview/public/components/overview/overview.tsx b/src/plugins/opensearch_dashboards_overview/public/components/overview/overview.tsx
@@ -222,7 +222,7 @@ export const Overview: FC<Props> = ({ newsFetchResult, solutions, features, bran
                       <h2 id="osdOverviewMore__title">
                         <FormattedMessage
                           id="opensearchDashboardsOverview.more.title"
-                          defaultMessage="Do more with Elastic"
+                          defaultMessage="Do more with OpenSearch"
                         />
                       </h2>
                     </EuiTitle>

diff --git a/src/plugins/telemetry/common/constants.ts b/src/plugins/telemetry/common/constants.ts
@@ -42,7 +42,7 @@ export const getConfigTelemetryDesc = () => {
   // Can't find where it's used but copying it over from the legacy code just in case...
   return i18n.translate('telemetry.telemetryConfigDescription', {
     defaultMessage:
-      'Help us improve the OpenSearch Stack by providing usage statistics for basic features. We will not share this data outside of Elastic.',
+      'Help us improve the OpenSearch Stack by providing usage statistics for basic features. We will not share this data outside of OpenSearch.',
   });
 };
 

diff --git a/src/plugins/visualizations/server/plugin.ts b/src/plugins/visualizations/server/plugin.ts
@@ -83,10 +83,13 @@ export class VisualizationsPlugin
           defaultMessage: 'Disable visualizations bucket aggregation types',
         }),
         value: [],
-        description: i18n.translate('visualizations.advancedSettings.visualizeDisableBucketAgg', {
-          defaultMessage: `A comma-separated list of bucket aggregations' names. e.g. significant_terms, terms.
+        description: i18n.translate(
+          'visualizations.advancedSettings.visualizeDisableBucketAgg.description',
+          {
+            defaultMessage: `A comma-separated list of bucket aggregations' names. e.g. significant_terms, terms.
             Deactivates the specified bucket aggregations from visualizations.`,
-        }),
+          }
+        ),
         category: ['visualization'],
         schema: schema.arrayOf(schema.string()),
       },