address comments

Signed-off-by: Su <[email protected]>
opensearch-project · Apr 5, 2023 · 8cce371 · 8cce371
1 parent 26fae2a
commit 8cce371
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -167,7 +167,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - [Vis Builder] Removed Hard Coded Strings and Used i18n to transalte([#2867](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2867))
 - [Console] Replace jQuery.ajax with core.http when calling OSD APIs in console ([#3080](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3080))
 - [I18n] Fix Listr type errors and error handlers ([#3629](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3629))
-- [Multiple DataSource]Refactor authentication type selection in create and edit data source forms to use EuiSelect ([#3693](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3693))
+- [Multiple DataSource] Present the authentication type choices in a drop-down ([#3693](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3693))
 
 ### 🔩 Tests
 

diff --git a/...agement/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx b/...agement/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
@@ -741,7 +741,7 @@ export class EditDataSourceForm extends React.Component<EditDataSourceProps, Edi
           <EuiSelect
             options={credentialSourceOptions}
             value={this.state.auth.type}
-            onChange={(e) => this.onChangeAuthType(e)}
+            onChange={this.onChangeAuthType}
             name="Credential"
             data-test-subj="editDataSourceSelectAuthType"
           />

diff --git a/src/plugins/data_source_management/public/types.ts b/src/plugins/data_source_management/public/types.ts
@@ -15,6 +15,7 @@ import {
 } from 'src/core/public';
 import { ManagementAppMountParams } from 'src/plugins/management/public';
 import { SavedObjectAttributes } from 'src/core/types';
+import { i18n } from '@osd/i18n';
 import { OpenSearchDashboardsReactContextValue } from '../../opensearch_dashboards_react/public';
 
 // eslint-disable-next-line @typescript-eslint/no-empty-interface
@@ -57,9 +58,24 @@ export enum AuthType {
 }
 
 export const credentialSourceOptions = [
-  { value: AuthType.NoAuth, text: 'No authentication' },
-  { value: AuthType.UsernamePasswordType, text: 'Username & Password' },
-  { value: AuthType.SigV4, text: 'AWS SigV4' },
+  {
+    value: AuthType.NoAuth,
+    text: i18n.translate('dataSourceManagement.credentialSourceOptions.NoAuthentication', {
+      defaultMessage: 'No authentication',
+    }),
+  },
+  {
+    value: AuthType.UsernamePasswordType,
+    text: i18n.translate('dataSourceManagement.credentialSourceOptions.UsernamePassword', {
+      defaultMessage: 'Username & Password',
+    }),
+  },
+  {
+    value: AuthType.SigV4,
+    text: i18n.translate('dataSourceManagement.credentialSourceOptions.AwsSigV4', {
+      defaultMessage: 'AWS SigV4',
+    }),
+  },
 ];
 
 export interface DataSourceAttributes extends SavedObjectAttributes {