Add changelog and other fixes

Signed-off-by: abbyhu2000 <[email protected]>
opensearch-project · Jul 6, 2023 · 5dbc8f9 · 5dbc8f9
1 parent 8ef8e34
commit 5dbc8f9
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -31,6 +31,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Bump OUI to `1.1.2` to make `anomalyDetection` icon available ([#4408](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4408))
 - Add `color-scheme` to the root styling ([#4477](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4477))
 - [Multiple DataSource] Frontend support for adding sample data ([#4412](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4412))
+- Dashboard De-Angularization ([#4502](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4502))
 
 ### 🐛 Bug Fixes
 

diff --git a/src/plugins/dashboard/public/application/embeddable/grid/_dashboard_grid.scss b/src/plugins/dashboard/public/application/embeddable/grid/_dashboard_grid.scss
@@ -82,7 +82,7 @@
     &:hover,
     &:focus {
       // TODO: this is a sass error, $embEditingModeHoverColor is undefined, comment it out for now
-      //background-color: $embEditingModeHoverColor;
+      // background-color: $embEditingModeHoverColor;
     }
   }
 

diff --git a/src/plugins/dashboard/public/application/utils/get_dashboard_instance.tsx b/src/plugins/dashboard/public/application/utils/get_dashboard_instance.tsx
@@ -30,10 +30,11 @@ export const getDashboardInstance = async (
 
   // Get the existing dashboard/default new dashboard from saved object loader
   const savedDashboard: SavedObjectDashboard = await savedDashboards.get(opts);
+
   // Serialized the saved object dashboard
   const serializedDashboard = convertToSerializedDashboard(savedDashboard);
+
   // Create a Dashboard class using the serialized dashboard
-  // const dashboard = (await dashboards.createDashboard(serializedDashboard)) as Dashboard;
   const dashboard = new Dashboard(serializedDashboard);
   await dashboard.setState(serializedDashboard);
 

diff --git a/src/plugins/dashboard/public/dashboard.ts b/src/plugins/dashboard/public/dashboard.ts
@@ -16,6 +16,8 @@
 import { cloneDeep } from 'lodash';
 import { Filter, ISearchSource, Query, RefreshInterval } from '../../data/public';
 import { SavedDashboardPanel } from './types';
+
+// TODO: This class can be revisited and clean up more
 export interface SerializedDashboard {
   id?: string;
   timeRestore: boolean;