Skip to content

Commit

Permalink
[Bug][DataSource] No restriction on setting default data source (#7396)
Browse files Browse the repository at this point in the history
* No restriction on setting default data source

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #7396 created/updated

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 5ee9b69)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
1 parent 5922b6a commit 585adac
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/7396.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- [DataSource] No restriction on setting default data source ([#7396](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7396))
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,5 @@ describe('Datasource Management: Edit Datasource Header', () => {
expect(component.find(headerTitleIdentifier).last().text()).toBe(dataSourceName);
expect(component.find(deleteIconIdentifier).exists()).toBe(false);
});
test('should not show default icon', () => {
expect(component.find(setDefaultButtonIdentifier).exists()).toBe(false);
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,7 @@ export const Header = ({
<EuiFlexItem grow={false}>
<EuiFlexGroup alignItems="baseline" gutterSize="m" responsive={false}>
{/* Test default button */}
{canManageDataSource ? (
<EuiFlexItem grow={false}>{renderDefaultIcon()}</EuiFlexItem>
) : null}
<EuiFlexItem grow={false}>{renderDefaultIcon()}</EuiFlexItem>
{/* Test connection button */}
<EuiFlexItem grow={false}>{renderTestConnectionButton()}</EuiFlexItem>
{/* Delete icon button */}
Expand Down

0 comments on commit 585adac

Please sign in to comment.