Skip to content

Commit

Permalink
Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests
Browse files Browse the repository at this point in the history
The latest version of chromedriver is 112.0.1 which does not support
node 14. This PR hardcodes chromedriver to 112.0.0 temporarily. Pls
revert it once we bump to node 18.

Issue Resolved
#3975

Signed-off-by: ananzh <[email protected]>
  • Loading branch information
ananzh committed May 3, 2023
1 parent ca0bb8f commit 4ee3fca
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions scripts/upgrade_chromedriver.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ if (majorVersion) {
if (process.argv.includes('--install')) {
console.log(`Installing chromedriver@^${majorVersion}`);

spawnSync(`yarn add --dev chromedriver@^${majorVersion}`, {
// Temporary fix: Install chromedriver 112.0.0; revert this once Node is bumped to 16+
spawnSync('yarn add --dev [email protected]', {
stdio: 'inherit',
cwd: process.cwd(),
shell: true,
Expand All @@ -90,10 +91,8 @@ if (majorVersion) {
});
rl.on('line', (line) => {
if (line.includes('"chromedriver": "')) {
line = line.replace(
/"chromedriver":\s*"[~^]?\d[\d.]*\d"/,
`"chromedriver": "^${majorVersion}"`
);
// Temporary fix: Use exact version 112.0.0; revert this once Node is bumped to 16+
line = line.replace(/"chromedriver":\s*"[~^]?\d[\d.]*\d"/, `"chromedriver": "112.0.0"`);
upgraded = true;
}
writeStream.write(line + '\n', 'utf8');
Expand Down

0 comments on commit 4ee3fca

Please sign in to comment.