Skip to content

Commit

Permalink
[Purify] hide option for theme version in settings (#1598) (#1603)
Browse files Browse the repository at this point in the history
There is currently to a PR to remove the v7 and v8 (beta) theme
versions within the application but it is getting stale:
#978

Since the v8 (beta) theme isn't actually planned and has the incorrect
version, we do not want end users to be able to change this setting.
In the essence of time, this will prevent this setting from showing in
the Advanced Settings page but will also not break users who set this
version already (however it will lock them into theme until they switched
by manually updating or deleting the config doc). Removing this setting
will force the default to be v8 (beta).

Temporary fix for:
#494

But it should be removed completely.

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 87e5412)

Co-authored-by: Kawika Avilla <[email protected]>
  • Loading branch information
opensearch-trigger-bot[bot] and kavilla authored May 19, 2022
1 parent 5a63c74 commit 45e0f28
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions release-notes/opensearch-dashboards.release-notes-2.0.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#### Deprecations
* Deprecates non-inclusive config names ([#1467](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1467))
* Removes UI Framework KUI doc site ([#1379](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1379))
* [Purify] hide option for theme version in settings ([#1598](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1598))

### 🛡 Security
* [CVE-2022-1537] Resolves grunt to 1.5.3 ([#1580](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1580))
Expand Down
1 change: 1 addition & 0 deletions src/core/server/ui_settings/settings/theme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export const getThemeSettings = (): Record<string, UiSettingsParams> => {
}),
requiresPageReload: true,
schema: schema.oneOf([schema.literal('v7'), schema.literal('v8 (beta)')]),
readonly: true,
},
};
};

0 comments on commit 45e0f28

Please sign in to comment.