Skip to content

Commit

Permalink
Fix (TableVis): Properly filter table columns when sending to filter … (
Browse files Browse the repository at this point in the history
#5619)

* Fix (TableVis): Properly filter table columns when sending to filter event handler

Signed-off-by: Josh Romero <[email protected]>

* add changelog

Signed-off-by: Josh Romero <[email protected]>

---------

Signed-off-by: Josh Romero <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
  • Loading branch information
joshuarrrr and ashwin-pc authored Feb 6, 2024
1 parent 1eb2f8b commit 3e22939
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Discover] Fix missing index pattern field from breaking Discover [#5626](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5626)
- [BUG] Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 ([5668](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5668))
- [BUG][Multiple Datasource] Fix datasource testing connection unexpectedly passed with wrong endpoint [#5663](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5663)
- [Table Visualization] Fix filter action buttons for split table aggregations ([#5619](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5619))
- [BUG][Multiple Datasource] Datasource id is required if multiple datasource is enabled and no default cluster supported [#5751](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5751)

### 🚞 Infrastructure
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,15 @@ export const getDataGridColumns = (
event: IInterpreterRenderHandlers['event'],
columnWidths: ColumnWidth[]
) => {
const formattedColumnIds = table.formattedColumns.map((column) => column.id);
const filterBucket = (rowIndex: number, columnIndex: number, negate: boolean) => {
event({
name: 'filterBucket',
data: {
data: [
{
table: {
columns: table.columns,
columns: table.columns.filter((column) => formattedColumnIds.includes(column.id)),
rows: table.rows,
},
row: rowIndex,
Expand Down

0 comments on commit 3e22939

Please sign in to comment.