Skip to content

Commit

Permalink
Simplifies re2 upgrade instructions (#3328) (#3561)
Browse files Browse the repository at this point in the history
* Follow-up from #3018

Signed-off-by: Tommy Markley <[email protected]>
(cherry picked from commit 844059c)

Co-authored-by: Tommy Markley <[email protected]>
(cherry picked from commit 3107769)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
  • Loading branch information
github-actions[bot] committed Mar 9, 2023
1 parent 9344b10 commit 29950ce
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/dev/build/tasks/patch_native_modules_task.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,16 @@ interface Package {
>;
}

/* Process for updating URLs and checksums after bumping the version of `re2` or NodeJS:
* 1. Match the `version` with the version in the yarn.lock file.
* 2. Match the module version, the digits at the end of the filename, with the output of
* `node -p process.versions.modules`.
* 3. Confirm that the URLs exist for each platform-architecture combo on
* https://github.com/uhop/node-re2/releases/tag/[VERSION]; reach out to maintainers for ARM
* releases of `re2` as they currently don't have an official ARM release.
* 4. Generate new checksums for each artifact by downloading each one and calling
* `shasum -a 256` or `sha256sum` on the downloaded file.
*/
const packages: Package[] = [
{
name: 're2',
Expand Down

0 comments on commit 29950ce

Please sign in to comment.