Skip to content

Commit

Permalink
[MD] Validate length of title to be less or equal than 32 characters (#…
Browse files Browse the repository at this point in the history
…6452) (#6476)

Signed-off-by: Zhongnan Su <[email protected]>
(cherry picked from commit 236ec4e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
1 parent 9cbfa64 commit 2740921
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ describe('DataSourceManagement: Form Validation', () => {
);
expect(result).toBe(false);
});
test('should fail validation when title is longer than 32 characters', () => {
form.title = 'test'.repeat(10);
const result = performDataSourceFormValidation(form, [], '', authenticationMethodRegistry);
expect(result).toBe(false);
});
test('should fail validation when endpoint is not valid', () => {
form.endpoint = mockDataSourceAttributesWithAuth.endpoint;
const result = performDataSourceFormValidation(form, [], '', authenticationMethodRegistry);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,14 @@ export const isTitleValid = (
error: '',
};
/* Title validation */
if (!title?.trim?.().length) {
if (!title.trim().length) {
isValid.valid = false;
} else if (title.length > 32) {
/* title length validation */
isValid.valid = false;
isValid.error = i18n.translate('dataSourcesManagement.validation.titleLength', {
defaultMessage: 'Title must be no longer than 32 characters',
});
} else if (
title.toLowerCase() !== existingTitle.toLowerCase() &&
Array.isArray(existingDatasourceNamesList) &&
Expand Down

0 comments on commit 2740921

Please sign in to comment.