Merge branch 'feature/table-revert' into table-settings-1

Signed-off-by: Anan Zhuang <[email protected]>
opensearch-project · Feb 2, 2024 · 1559937 · 1559937
2 parents 17da93f + 0246257
commit 1559937
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 10 deletions.
diff --git a/src/plugins/discover/public/application/components/default_discover_table/_table_cell.scss b/src/plugins/discover/public/application/components/default_discover_table/_table_cell.scss
@@ -2,8 +2,13 @@
   border-top: none !important;
 }
 
-.osdDocTableCell__toggleDetails {
-  padding: 7px 0 0 4px;
+// stylelint-disable-next-line @osd/stylelint/no_modifying_global_selectors
+.euiFlexItem.osdDocTable__detailsIconContainer {
+  margin-right: 0;
+}
+
+.osd-table td.osdDocTableCell__toggleDetails {
+  padding: 5px 0 0 4px;
 }
 
 /**

diff --git a/src/plugins/discover/public/application/components/default_discover_table/table_rows.tsx b/src/plugins/discover/public/application/components/default_discover_table/table_rows.tsx
@@ -130,9 +130,9 @@ export const TableRow = ({
 
   const expandedTableRow = (
     <tr key={'x' + row._id}>
-      <td className="osdDocTable__detailsParent" colSpan={columns.length + 2}>
-        <EuiFlexGroup>
-          <EuiFlexItem grow={false}>
+      <td className="osdDocTable__detailsParent" colSpan={columnIds.length + 1}>
+        <EuiFlexGroup gutterSize="m" alignItems="center">
+          <EuiFlexItem grow={false} className="osdDocTable__detailsIconContainer">
             <EuiIcon type="folderOpen" />
           </EuiFlexItem>
           <EuiFlexItem>
@@ -149,7 +149,7 @@ export const TableRow = ({
             <DocViewerLinks hit={row} indexPattern={indexPattern} columns={columns} />
           </EuiFlexItem>
         </EuiFlexGroup>
-        <EuiFlexGroup>
+        <EuiFlexGroup gutterSize="m">
           <EuiFlexItem>
             <DocViewer
               hit={row}

diff --git a/src/plugins/discover/public/application/components/top_nav/table_feedbacks_panel.tsx b/src/plugins/discover/public/application/components/top_nav/table_feedbacks_panel.tsx
@@ -31,11 +31,11 @@ export const TableFeedbacksPanel = ({ onClose, onTurnOff }: TableFeedbacksPanelP
     <EuiModalBody>
       <EuiText>
         <p>
-          Event tables: Documents are now expanded through a flyout. Density, column order, and
-          sorting controls have been improved.{' '}
+          Help drive future improvements by{' '}
           <a href="https://survey.opensearch.org" target="_blank" rel="noopener noreferrer">
-            Provide feedbacks
-          </a>
+            providing feedback
+          </a>{' '}
+          about your experience.
         </p>
       </EuiText>
     </EuiModalBody>