remove query validation

Signed-off-by: Hailong Cui <[email protected]>
opensearch-project · Sep 12, 2024 · 14002d7 · 14002d7
1 parent 6bb95a5
commit 14002d7
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 34 deletions.
diff --git a/src/core/server/ui_settings/routes/delete.ts b/src/core/server/ui_settings/routes/delete.ts
@@ -33,18 +33,11 @@ import { schema } from '@osd/config-schema';
 import { IRouter } from '../../http';
 import { SavedObjectsErrorHelpers } from '../../saved_objects';
 import { CannotOverrideError } from '../ui_settings_errors';
-import { UiSettingScope } from '../types';
 
 const validate = {
   params: schema.object({
     key: schema.string(),
   }),
-  query: schema.object({
-    scope: schema.maybe(
-      schema.oneOf([schema.literal(UiSettingScope.GLOBAL), schema.literal(UiSettingScope.USER)])
-    ),
-    security_tenant: schema.maybe(schema.any()),
-  }),
 };
 
 export function registerDeleteRoute(router: IRouter) {

diff --git a/src/core/server/ui_settings/routes/get.ts b/src/core/server/ui_settings/routes/get.ts
@@ -28,24 +28,12 @@
  * under the License.
  */
 
-import { schema } from '@osd/config-schema';
-
 import { IRouter } from '../../http';
 import { SavedObjectsErrorHelpers } from '../../saved_objects';
-import { UiSettingScope } from '../types';
-
-const validate = {
-  query: schema.object({
-    scope: schema.maybe(
-      schema.oneOf([schema.literal(UiSettingScope.GLOBAL), schema.literal(UiSettingScope.USER)])
-    ),
-    security_tenant: schema.maybe(schema.any()),
-  }),
-};
 
 export function registerGetRoute(router: IRouter) {
   router.get(
-    { path: '/api/opensearch-dashboards/settings', validate },
+    { path: '/api/opensearch-dashboards/settings', validate: false },
     async (context, request, response) => {
       try {
         const uiSettingsClient = context.core.uiSettings.client;

diff --git a/src/core/server/ui_settings/routes/set.ts b/src/core/server/ui_settings/routes/set.ts
@@ -33,7 +33,6 @@ import { schema, ValidationError } from '@osd/config-schema';
 import { IRouter } from '../../http';
 import { SavedObjectsErrorHelpers } from '../../saved_objects';
 import { CannotOverrideError } from '../ui_settings_errors';
-import { UiSettingScope } from '../types';
 
 const validate = {
   params: schema.object({
@@ -42,12 +41,6 @@ const validate = {
   body: schema.object({
     value: schema.any(),
   }),
-  query: schema.object({
-    scope: schema.maybe(
-      schema.oneOf([schema.literal(UiSettingScope.GLOBAL), schema.literal(UiSettingScope.USER)])
-    ),
-    security_tenant: schema.maybe(schema.any()),
-  }),
 };
 
 export function registerSetRoute(router: IRouter) {

diff --git a/src/core/server/ui_settings/routes/set_many.ts b/src/core/server/ui_settings/routes/set_many.ts
@@ -33,18 +33,11 @@ import { schema, ValidationError } from '@osd/config-schema';
 import { IRouter } from '../../http';
 import { SavedObjectsErrorHelpers } from '../../saved_objects';
 import { CannotOverrideError } from '../ui_settings_errors';
-import { UiSettingScope } from '../types';
 
 const validate = {
   body: schema.object({
     changes: schema.object({}, { unknowns: 'allow' }),
   }),
-  query: schema.object({
-    scope: schema.maybe(
-      schema.oneOf([schema.literal(UiSettingScope.GLOBAL), schema.literal(UiSettingScope.USER)])
-    ),
-    security_tenant: schema.maybe(schema.any()),
-  }),
 };
 
 export function registerSetManyRoute(router: IRouter) {