address suggestions

Signed-off-by: Ajay Gupta <[email protected]>
opensearch-project · Dec 7, 2022 · 0742011 · 0742011
1 parent a6ba2f7
commit 0742011
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/src/dev/build/tasks/os_packages/docker_generator/resources/bin/opensearch-dashboards-docker b/src/dev/build/tasks/os_packages/docker_generator/resources/bin/opensearch-dashboards-docker
@@ -160,6 +160,7 @@ opensearch_dashboards_vars=(
     data_source.audit.appender.layout.kind
     data_source.audit.appender.layout.highlight
     data_source.audit.appender.layout.pattern
+    pit.enabled
 )
 
 longopts=''

diff --git a/src/plugins/point_in_time_management/opensearch_dashboards.json b/src/plugins/point_in_time_management/opensearch_dashboards.json
@@ -1,5 +1,5 @@
 {
-  "id": "pointInTimeManagement",
+  "id": "pit",
   "version": "1.0.0",
   "opensearchDashboardsVersion": "opensearchDashboards",
   "server": true,

diff --git a/..._in_time_management/public/components/empty_state/__snapshots__/empty_state.test.tsx.snap b/..._in_time_management/public/components/empty_state/__snapshots__/empty_state.test.tsx.snap
diff --git a/src/plugins/point_in_time_management/public/components/empty_state/empty_state.tsx b/src/plugins/point_in_time_management/public/components/empty_state/empty_state.tsx
@@ -39,7 +39,7 @@ export const EmptyState = () => {
               </h1>
             </EuiTitle>
           </EuiPageContentHeaderSection>
-          <EuiButton fill={true} iconType="plusInCircle">
+          <EuiButton fill={true} iconType="plusInCircle" data-test-subj="createPITBtnInHeader">
             <FormattedMessage
               id="pointInTimeManagement.header.createPointInTimeButton"
               defaultMessage="Create point in time"
@@ -64,7 +64,7 @@ export const EmptyState = () => {
           >
             <EuiFlexItem grow={false}>No point in time objects have been created yet.</EuiFlexItem>
             <EuiSpacer />
-            <EuiButton>
+            <EuiButton data-test-subj="createPITBtnInBody">
               <FormattedMessage
                 id="pointInTimeManagement.createPointInTimeButton"
                 defaultMessage="Create point in time"