Skip to content

Commit

Permalink
Don't terminate the server on NodeDeprecationWarning (#1185)
Browse files Browse the repository at this point in the history
The last AWS SDK for Javascript that supports Node 10 (v3.45.0) emits a NodeDeprecationWarning to indicate that Node 10
is no longer supported. Without this workaround, this crashes the OSD server, so it becomes impossible to interact with
other AWS services from within OSD (e.g., in a custom plugin) until the Node 14 upgrade is done.

Signed-off-by: Thilo-Alexander Ginkel <[email protected]>
  • Loading branch information
ginkel authored Feb 4, 2022
1 parent 0c3f901 commit 06d06a9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/setup_node_env/exit_on_warning.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
*/

if (process.noProcessWarnings !== true) {
var ignore = ['MaxListenersExceededWarning'];
var ignore = ['MaxListenersExceededWarning', 'NodeDeprecationWarning'];

process.on('warning', function (warn) {
if (ignore.includes(warn.name)) return;
Expand Down

0 comments on commit 06d06a9

Please sign in to comment.