Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits #38

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Minor edits #38

merged 6 commits into from
Feb 13, 2024

Conversation

sepandhaghighi
Copy link
Member

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • README.md updated
  • dependabot.yml added
  • Minor edits in RELEASE.md

Any other comments?

@sepandhaghighi sepandhaghighi added the documentation Improvements or additions to documentation label Feb 12, 2024
@sepandhaghighi sepandhaghighi added this to the nava v0.4 milestone Feb 12, 2024
@sepandhaghighi sepandhaghighi self-assigned this Feb 12, 2024
@sadrasabouri
Copy link
Member

@sepandhaghighi Can you also fix Codacy failing status for dev branch on MacOS and Linux?
Linux Failing Codacy Badge

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3840172) 99.19% compared to head (f815f73) 99.19%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #38   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files           4        4           
  Lines         124      124           
  Branches       12       12           
=======================================
  Hits          123      123           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sepandhaghighi sepandhaghighi marked this pull request as ready for review February 13, 2024 06:22
@sepandhaghighi
Copy link
Member Author

@sepandhaghighi Can you also fix Codacy failing status for dev branch on MacOS and Linux? Linux Failing Codacy Badge

Fixed in f815f73

@sadrasabouri
Copy link
Member

I would test it on MacOS tomorrow and review this process.

Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it on MacOS and yes it can also play mp3.

@sadrasabouri sadrasabouri merged commit e50f881 into dev Feb 13, 2024
73 checks passed
@sadrasabouri sadrasabouri deleted the minor_edits branch February 13, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants