-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for dev containers #123
Conversation
This image is based on Tom Palmer's rebuild of the r-docker image, used in the OpenSAFELY pipeline. It provides the same version of R and copies over all required packages. It also packages RStudio for use with devcontainers. The image also provides the version of Python used by the OpenSAFELY pipeline and copies over the required Python packages. The ehrql library isn't compatible with this version of Python, so isn't installed. Co-authored-by: Jon Massey <[email protected]>
Co-authored-by: Jon Massey <[email protected]>
This uses the standard Rocker image and saves use over 3 gig in space (see [comment](opensafely-core#9 (comment))). It also moves the renv setup into a separate script, where we also setup the rstudio environment.
The ehrql extension is downloaded and referenced in vs code separately rather than being installed using pip because it requires a newer version of python (3.11 rather than the 3.10 required for the analysis code). Co-authored-by: Jon Massey <[email protected]>
This is so we can use the packages copied over from the python action image. Co-authored-by: Jon Massey <[email protected]>
The python symlinks included in the virtualenv copied from the Python Action image point to /usr/bin/python3, so we need to ensure that points to the correct version of python.
For this initial version, I build the image locally and uploaded it using these [instructions](https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry).
Ubuntu PPA domains changed in 2022; although the old ones were supposed to remain indefinitely, they're currently inaccessible; but we should update to the new one anyway https://blog.launchpad.net/ppa/new-domain-names-for-ppas
This matches the behaviour of GitHub Desktop and is likely to be the behaviour that users expect. If this causes any problems we can disable it again.
and remove vestigial config added for gitpod
84f6d2d
to
8c646bd
Compare
f10b2e3
to
aa5acaa
Compare
It would be worth considering moving this into the research-template-docker repo to avoid too much cruft in this repo. We'll want to add things like alerts into slack, which will add extra things that we probably don't want/need here. We already have a very basic test of the dev container docker image there, so this builds on that work. It looks like the checkout action supports pulling in other repos, so I think it should work.
|
It's looking like building against macos is a bit more complicated than expected. For now, I would focus on getting it working against ubuntu:latest, which is presumably what GitHub use for Codespaces. Apologies if you've already thought about this, but I wanted to respond while I had some spare time. |
I'd already dropped macOS as an idea. Essentially:
That's fine; I'll do that 😎 |
2295841
to
19509fb
Compare
No description provided.