Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viv3ckj/update graphs #42

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Viv3ckj/update graphs #42

merged 4 commits into from
Oct 18, 2024

Conversation

viv3ckj
Copy link
Contributor

@viv3ckj viv3ckj commented Oct 18, 2024

Closes #41

@viv3ckj viv3ckj marked this pull request as ready for review October 18, 2024 13:35
Copy link
Member

@milanwiedemann milanwiedemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks like we're almost there just some final comments:

  • not all figures are the same size, could you make sure that they are all 4x4inch (or similar) for each plot? for example the total population plots would need the following chunk options fig.height=4, fig.width=8.
  • the idea setting the colours manualle is great and works! we just have some repetition we can avoid by defining an object with each colour scale at the top of the script, e.g.,
imd_colour_values <- c("#001F4D", "#0056B3", "#007BFF", "#66B3E2", "#A4D8E1", "grey")
region_colour_values <- ...

analysis/measures_definition_pf_codes_conditions.py Outdated Show resolved Hide resolved
lib/functions/function_plot_measures.R Outdated Show resolved Hide resolved
@viv3ckj viv3ckj merged commit 8a1fed8 into main Oct 18, 2024
1 check passed
@viv3ckj viv3ckj deleted the viv3ckj/update-graphs branch October 18, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update graphs
2 participants