Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quoting of cli args in wrapper script to properly expand arguments. #10

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Fix quoting of cli args in wrapper script to properly expand arguments. #10

merged 1 commit into from
Jul 19, 2021

Conversation

bloodearnest
Copy link
Member

Also, fix some issue with the tests, and use this to test that multiple
args are passed

@bloodearnest
Fix quoting but in wrapper script to properly expand arguments.
cc02233 
Also, fix some issue with the tests, and use this to test that multiple
args are passed
@bloodearnest bloodearnest changed the title Fix quoting but in wrapper script to properly expand arguments. Fix quoting of cli args in wrapper script to properly expand arguments. Jul 19, 2021
CarolineMorton
CarolineMorton approved these changes Jul 19, 2021
View reviewed changes
Copy link

@CarolineMorton CarolineMorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Such a good spot

@bloodearnest bloodearnest merged commit 08c7872 into main Jul 19, 2021
@bloodearnest bloodearnest deleted the fix-arg-quoting branch July 19, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarolineMorton CarolineMorton CarolineMorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bloodearnest @CarolineMorton