Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create version 4.0 #341

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Create version 4.0 #341

merged 3 commits into from
Oct 8, 2024

Conversation

alarthast
Copy link
Contributor

@alarthast alarthast commented Oct 4, 2024

Part of #224 .

Version 4 removes support for cohort extractor actions. It therefore no longer mandates an expectations configuration in the project.yaml file, and raises a ValidationError if the file includes a cohort extractor action.

The expectations attribute of the Pipeline class for v4 is now None rather than an Expectations class. This is new, so the v4 pipeline release needs to be tested before we switch the research-template to using it.

Copy link
Contributor

@evansd evansd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciated the logical sequencing of the commits here. It made it very easy to review.

If you wanted to test this in action with a real project without having to first dance around updating a chain of four different packages, there is a way to do so.

The opensafely run command is just a wrapper around a command in job-runner called local_run. So you could do something like this:

  1. Get job-runner checked out and working locally.

  2. Install your version of the pipeline library directly from this branch:

    pip install pip install opensafely-pipeline@git+https://github.com/opensafely-core/pipeline@create-v4
    
  3. Run:

    python -m jobrunner.cli.local_run --project-dir <path/to/some/project>
    

@alarthast
Copy link
Contributor Author

Followed the above instructions and locally things are as expected.

@alarthast alarthast merged commit 840ea82 into main Oct 8, 2024
16 checks passed
@alarthast alarthast deleted the create-v4 branch October 8, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants