Remove pydantic dependency #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebbacon
reviewed
Sep 26, 2024
|
You've missed updating the README (i.e. it mentions pydantic) (sorry for a very random driveby not-a-review!) |
They'll get in the way and we'll reinstate them later
We lose the ability to report more than one error at once, but the code is simpler.
Again, we lose the ability to report more than one error at once, but the code is simpler.
(It doesn't raise AssertionError)
This came for free with pydantic.
I'd assumed that pydantic did this, but it turns out it doesn't. Feels like it's worth checking for, as extra parameters are likely to be a mistake.
inglesp
force-pushed
the
remove-pydantic
branch
from
9f15198 to
ecf3e31
Compare
evansd
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency on pydantic has caused several issues. This PR removes the dependency. We still perform all custom validation (eg that output paths are unique), and I have attempted to approximately replicate the type-based validation that pydantic does.
All existing tests pass, with minimal modifications, and there are new tests to cover the type-based validation.
Fixes opensafely-core/job-server#4557.