Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transitive dependencies of environs #2220

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

StevenMaude
Copy link
Contributor

No description provided.

@StevenMaude StevenMaude self-assigned this Dec 10, 2024
@StevenMaude
Copy link
Contributor Author

As mentioned in this update of environs, environs is used only in opencodelists/settings.py.

I tested this locally: environment variables do get loaded.

@StevenMaude StevenMaude removed their assignment Dec 10, 2024
@evansd
Copy link
Contributor

evansd commented Dec 10, 2024

FWIW, we opted not to use this Airlock specifically because its transitive dependencies seemed pretty heavyweight for the value it gave. Not saying you shouldn't use it, but worth bearing in mind if you're in the process of reconsidering this stuff.
https://bennettoxford.slack.com/archives/C069YDR4NCA/p1723201362723169

@StevenMaude
Copy link
Contributor Author

its transitive dependencies seemed pretty heavyweight for the value it gave

Agree that this is a good candidate for removal, here and in job-server.

(And I similarly looked at the dependency subtree with some questioning 🤨🔍)

I don't think it blocks merging this PR in the meantime so we can keep things up-to-date, in the current state, ahead of getting round to #2222.

@StevenMaude StevenMaude merged commit 38fbc02 into main Dec 11, 2024
6 checks passed
@StevenMaude StevenMaude deleted the steve/update-environs-transitive-dependencies branch December 11, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants