Update backend state on GET requests #4758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in the linked ticket, previously we only updated this state on POST requests. This meant that when we entered database maintenance mode this would only become visible to users once a job was actually running. This has repeatedly caused minor confusion and annoyance. We were already updating the "last seen" stats for the backend on every GET, so this just extends this slightly. Closes #4605
evansd
force-pushed
the
evansd/update-flags-on-get
branch
from
3addff4 to
57865e6
Compare
iaindillingham
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the linked ticket, previously we only updated this state on POST requests. This meant that when we entered database maintenance mode this would only become visible to users once a job was actually running. This has repeatedly caused minor confusion and annoyance.
We were already updating the "last seen" stats for the backend on every GET, so this just extends this slightly.
Closes #4605