Handle None gracefully in repository topics
#4738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually `repositoryTopics` is either like:
* `'repositoryTopics': {'nodes': []}`
* `'repositoryTopics': {'nodes': [{'topic': {'name': 'non-research'}}]}`
But it can be:
* `'repositoryTopics': {'nodes': [None]}`
This is as found from:
https://github.com/opensafely-testing/github-api-testing-topics
when running `TestGithubAPINonPrivate::test_get_repos_with_branches()`
That repository has no topics set.
Note that:
https://github.com/opensafely-testing/github-api-testing-private
which I don't have access to, has an empty list, and presumably no
topics set.
Maybe there's a distinction between "no topics because this repository
never had any topics set" and "no topics because this repository has had
topics deleted"?
We currently don't have any methods with underscores in `FakeGitHubAPIWithErrors`, so the branch of "name starts with an underscore" is never exercised. It's still useful to have a check for this, in case such methods are added in future.
|
This run with similar changes passed the tests. |
Jongmassey
approved these changes
Nov 12, 2024
mikerkelly
approved these changes
Nov 12, 2024
StevenMaude
deleted the
steve/fix-get-repos-with-branches-verification-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a failing verification test.