Add a new question to the "Study information" page #4483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaindillingham
force-pushed
the
iaindillingham/add-new-question-to-study-information-page
branch
from
8edd740 to
dba9c8f
Compare
iaindillingham
commented
Jul 23, 2024
| @@ -12,6 +12,7 @@ def __init__(self, *args, **kwargs): | |||
| # which uses choices. | |||
| radio_fields = [ | |||
| "all_applicants_completed_getting_started", | |||
| "read_analytic_methods_policy", | |||
There was a problem hiding this comment.
IKR, took me a second to work out why this was needed
There was a problem hiding this comment.
It made me very sad.
iaindillingham
force-pushed
the
iaindillingham/add-new-question-to-study-information-page
branch
from
dba9c8f to
3cddbda
Compare
iaindillingham
force-pushed
the
iaindillingham/add-new-question-to-study-information-page
branch
from
3cddbda to
0492431
Compare
Jongmassey
approved these changes
Jul 24, 2024
| @@ -113,6 +113,11 @@ | |||
| help_text=snippet("study_purpose-help_text"), | |||
| template_name="form_textarea", | |||
| ), | |||
| Field( | |||
| name="read_analytic_methods_policy", | |||
| label="Have all applicants for OpenSAFELY read and agreed to the OpenSAFELY Analytic Methods Policy?", | |||
There was a problem hiding this comment.
Suggested change
| label="Have all applicants for OpenSAFELY read and agreed to the OpenSAFELY Analytic Methods Policy?", | |
| label="Have all applicants read and agreed to the OpenSAFELY Analytic Methods Policy?", |
I think the "for OpenSAFELY" feels implicit here, but I'm aware there's been a bit of wrangling over the wording already so happy for you to disregard!
There was a problem hiding this comment.
Sadly, this isn't negotiable. I share your snag, however.
iaindillingham
deleted the
iaindillingham/add-new-question-to-study-information-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4467
Here's the question:
Notice that the link is in the help text below the question, not in the question itself.
Field.labelisn't parsed, butField.help_textis. I've asked Liam whether this suffices.1And here's the question in the context of the page:
No extra work is required to show the answer to the question in the staff area. The default answer is
null.Footnotes
https://bennettoxford.slack.com/archives/C068NDYALSF/p1721748150730279 ↩